[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6001: Flink: Fix NoClassDefFound with Flink runtime jar

[GitBox <gi...@apache.org>]

ajantha-bhat commented on code in PR #6001:
URL: https://github.com/apache/iceberg/pull/6001#discussion_r997762179


##########
flink/v1.14/build.gradle:
##########
@@ -119,7 +119,6 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
 
   configurations {
     implementation {
-      exclude group: 'org.apache.flink'

Review Comment:
   Nice catch. 
   
   Can we add a smoke test to Flink runtime jar to catch these kinds of issues?
    Spark is already having one here for its runtime jar. https://github.com/apache/iceberg/blob/master/spark/v3.3/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org