[jira] Commented: (HADOOP-4910) NameNode should exclude corrupt replicas when choosing excessive replicas to delete

["Raghu Angadi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661657#action_12661657 ] 

Raghu Angadi commented on HADOOP-4910:
--------------------------------------

+1 patch looks good. Simple but important fix.
minor nit : I would suggest removing reference to this jira in comments. Otherwise it gives an impression that reader should read this jira to understand what is happening, which is not necessary. 

> NameNode should exclude corrupt replicas when choosing excessive replicas to delete
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-4910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4910
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.17.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.18.3
>
>         Attachments: overReplicated.patch, overReplicated1.patch
>
>
> Currently, when NameNode handles an over-replicated block in FSNamesystem#processOverReplicatedBlock, it excludes ones already in excessReplicateMap and decommissed ones, but it treats a corrupt replica as a valid one. This may lead to unnecessary deletion of more replicas and thus cause data lose. It should exclude corrupt replicas as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.