[GitHub] [incubator-nemo] wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'

[GitBox <gi...@apache.org>]

wonook commented on a change in pull request #203: [NEMO-360] Implementing an 'XGBoostPolicy'
URL: https://github.com/apache/incubator-nemo/pull/203#discussion_r267295098
 
 

 ##########
 File path: client/pom.xml
 ##########
 @@ -71,41 +71,4 @@ under the License.
         <optional>true</optional>
       </dependency>
     </dependencies>
-
-
-  <build>
-    <plugins>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-deploy-plugin</artifactId>
-        <version>2.8.2</version>
-        <configuration>
-          <skip>true</skip>
-        </configuration>
-      </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-shade-plugin</artifactId>
-        <version>3.0.0</version>
-        <executions>
-          <execution>
-            <phase>package</phase>
-            <goals>
-              <goal>shade</goal>
-            </goals>
-            <configuration>
-              <outputFile>
-                ${project.build.directory}/${project.artifactId}-${project.version}-shaded.jar
-              </outputFile>
-              <transformers>
-                <!-- Required for using beam-hadoop: See https://stackoverflow.com/questions/44365545
-                -->
-                <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer" />
-              </transformers>
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
-    </plugins>
-  </build>
 
 Review comment:
   There had been unnecessary shading of the client package, and had been confusing the `run_beam.sh` script, resulting in job fails in distributed environments (not sure exactly, but this change was unnecessary)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services