You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/07/23 23:37:40 UTC
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13903
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
---
M docs/topics/impala_client.xml
1 file changed, 45 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/13903/1
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13903
to look at the new patch set (#2).
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
---
M docs/topics/impala_client.xml
1 file changed, 47 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/13903/2
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13903 )
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/410/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 21:11:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13903 )
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 21:26:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13903 )
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13903/1/docs/topics/impala_client.xml
File docs/topics/impala_client.xml:
http://gerrit.cloudera.org:8080/#/c/13903/1/docs/topics/impala_client.xml@132
PS1, Line 132: Impala closes any session started over that connection
There's always exactly one session per beeswax connection, created when the connection is established, so maybe word this more like "Impala closes the session associated with that connection"
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 17:17:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13903 )
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/410/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 21:24:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13903 )
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/401/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 23:37:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13903 )
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/401/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2019 00:00:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13903 )
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Reviewed-on: http://gerrit.cloudera.org:8080/13903
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M docs/topics/impala_client.xml
1 file changed, 47 insertions(+), 22 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Thomas Tauber-Marshall: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8616: [DOCS] Document --disconnected session timeout flag for HS2
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13903 )
Change subject: IMPALA-8616: [DOCS] Document --disconnected_session_timeout flag for HS2
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13903/1/docs/topics/impala_client.xml
File docs/topics/impala_client.xml:
http://gerrit.cloudera.org:8080/#/c/13903/1/docs/topics/impala_client.xml@132
PS1, Line 132: Impala closes any session started over that connection
> There's always exactly one session per beeswax connection, created when the
Done
--
To view, visit http://gerrit.cloudera.org:8080/13903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c178116ec9cb8abf619c9fdcfb2697bcfb1de5c
Gerrit-Change-Number: 13903
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 21:09:55 +0000
Gerrit-HasComments: Yes