You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/13 19:50:34 UTC

[GitHub] [incubator-superset] junlincc commented on pull request #10834: fix: dashboard edit/save errors

junlincc commented on pull request #10834:
URL: https://github.com/apache/incubator-superset/pull/10834#issuecomment-707970395


   @graceguo-supercat thanks for the additional feedback and they make sense to me. besides only having single API that does the job, we should also change `Save` label in the modal to `Finish` or `Done` to have more distinction from `Save` button on dashboard header. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org