You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/16 23:24:42 UTC

[GitHub] [geode] agingade commented on a change in pull request #5379: GEODE-8361: Use Set instead of List to track cleared buckets

agingade commented on a change in pull request #5379:
URL: https://github.com/apache/geode/pull/5379#discussion_r456132028



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java
##########
@@ -401,7 +395,7 @@ protected void handleClearFromDepartedMember(InternalDistributedMember departedM
     }
   }
 
-  class LockForListenerAndClientNotification {
+  static class LockForListenerAndClientNotification {

Review comment:
       Any reason for changing it to static? The PRClear is separate for each PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org