You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/30 17:25:51 UTC
[GitHub] [arrow] Crystrix opened a new pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Crystrix opened a new pull request #12299:
URL: https://github.com/apache/arrow/pull/12299
- If min_count == 0 and skip_nulls == true `hash_sum` returns an int64 scalar of 0, otherwise return a int64 scalar of null
- If min_count == 0 and skip_nulls == true `hash_product` returns an int64 scalar of 1, otherwise return a int64 scalar of null
- If min_count == 0 and skip_nulls == true `hash_mean` returns an float64 scalar of 0, otherwise return a float64 scalar of null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #12299:
URL: https://github.com/apache/arrow/pull/12299#discussion_r795687618
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -1091,8 +1153,17 @@ struct GroupedMeanImpl : public GroupedReducingAggregator<Type, GroupedMeanImpl<
}
};
+struct GroupedMeanNullImpl final : public GroupedNullImpl {
+ std::shared_ptr<DataType> out_type() const override { return float64(); }
+
+ void output_empty(const std::shared_ptr<Buffer>& data) override {
+ std::memset(data->mutable_data(), 0, num_groups_ * sizeof(double));
Review comment:
I'd rather use `std::fill_n(double*, ...)` here for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Crystrix commented on a change in pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Posted by GitBox <gi...@apache.org>.
Crystrix commented on a change in pull request #12299:
URL: https://github.com/apache/arrow/pull/12299#discussion_r797348794
##########
File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc
##########
@@ -1091,8 +1153,17 @@ struct GroupedMeanImpl : public GroupedReducingAggregator<Type, GroupedMeanImpl<
}
};
+struct GroupedMeanNullImpl final : public GroupedNullImpl {
+ std::shared_ptr<DataType> out_type() const override { return float64(); }
+
+ void output_empty(const std::shared_ptr<Buffer>& data) override {
+ std::memset(data->mutable_data(), 0, num_groups_ * sizeof(double));
Review comment:
@pitrou, `memset` is replaced with `fill_n`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12299:
URL: https://github.com/apache/arrow/pull/12299#issuecomment-1027926190
Benchmark runs are scheduled for baseline = 3f9daeb25fd471e85d584a2743f83a1abfe5fb3d and contender = 9e8ac565780233359d8d0957dcbc91cb1b6d3a50. 9e8ac565780233359d8d0957dcbc91cb1b6d3a50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47bd2ef8a23a4b928df2ae7f56c133ec...0874d2c95a064c648ace3852e94675a6/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4e4f98bbcebc4e0087f745a89d3f6862...b06e9a1663ae41d7b4de699ed5fa775d/)
[Finished :arrow_down:0.22% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15464373a4414e188bcfc207b36067c8...05c5cae09d064bd799facb1cfa954b4b/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12299:
URL: https://github.com/apache/arrow/pull/12299#issuecomment-1027926190
Benchmark runs are scheduled for baseline = 3f9daeb25fd471e85d584a2743f83a1abfe5fb3d and contender = 9e8ac565780233359d8d0957dcbc91cb1b6d3a50. 9e8ac565780233359d8d0957dcbc91cb1b6d3a50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47bd2ef8a23a4b928df2ae7f56c133ec...0874d2c95a064c648ace3852e94675a6/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4e4f98bbcebc4e0087f745a89d3f6862...b06e9a1663ae41d7b4de699ed5fa775d/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15464373a4414e188bcfc207b36067c8...05c5cae09d064bd799facb1cfa954b4b/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12299:
URL: https://github.com/apache/arrow/pull/12299#issuecomment-1025190119
https://issues.apache.org/jira/browse/ARROW-15506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12299:
URL: https://github.com/apache/arrow/pull/12299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12299:
URL: https://github.com/apache/arrow/pull/12299#issuecomment-1027926190
Benchmark runs are scheduled for baseline = 3f9daeb25fd471e85d584a2743f83a1abfe5fb3d and contender = 9e8ac565780233359d8d0957dcbc91cb1b6d3a50. 9e8ac565780233359d8d0957dcbc91cb1b6d3a50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47bd2ef8a23a4b928df2ae7f56c133ec...0874d2c95a064c648ace3852e94675a6/)
[Failed :arrow_down:0.71% :arrow_up:2.14%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4e4f98bbcebc4e0087f745a89d3f6862...b06e9a1663ae41d7b4de699ed5fa775d/)
[Finished :arrow_down:0.22% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15464373a4414e188bcfc207b36067c8...05c5cae09d064bd799facb1cfa954b4b/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12299: ARROW-15506: [C++][Compute] Support Null type in hash_sum/hash_product/hash_mean
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12299:
URL: https://github.com/apache/arrow/pull/12299#issuecomment-1027926190
Benchmark runs are scheduled for baseline = 3f9daeb25fd471e85d584a2743f83a1abfe5fb3d and contender = 9e8ac565780233359d8d0957dcbc91cb1b6d3a50. 9e8ac565780233359d8d0957dcbc91cb1b6d3a50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/47bd2ef8a23a4b928df2ae7f56c133ec...0874d2c95a064c648ace3852e94675a6/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4e4f98bbcebc4e0087f745a89d3f6862...b06e9a1663ae41d7b4de699ed5fa775d/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15464373a4414e188bcfc207b36067c8...05c5cae09d064bd799facb1cfa954b4b/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org