You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "0xPoe (via GitHub)" <gi...@apache.org> on 2025/11/07 17:26:24 UTC
[PR] feat: implement partition_statistics for WindowAggExec [datafusion]
0xPoe opened a new pull request, #18534:
URL: https://github.com/apache/datafusion/pull/18534
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Ref https://github.com/apache/datafusion/issues/15873
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Implemented partition_statistics for WindowAggExec.
## Are these changes tested?
Check the unit tests.
## Are there any user-facing changes?
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: implement partition_statistics for WindowAggExec [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 commented on code in PR #18534:
URL: https://github.com/apache/datafusion/pull/18534#discussion_r2652557644
##########
datafusion/physical-plan/src/windows/window_agg_exec.rs:
##########
@@ -159,8 +159,8 @@ impl WindowAggExec {
}
}
- fn statistics_inner(&self) -> Result<Statistics> {
- let input_stat = self.input.partition_statistics(None)?;
+ fn statistics_inner(&self, partition: Option<usize>) -> Result<Statistics> {
Review Comment:
Sounds good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: implement partition_statistics for WindowAggExec [datafusion]
Posted by "0xPoe (via GitHub)" <gi...@apache.org>.
0xPoe commented on PR #18534:
URL: https://github.com/apache/datafusion/pull/18534#issuecomment-3700551410
Rebased onto the main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: implement partition_statistics for WindowAggExec [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #18534:
URL: https://github.com/apache/datafusion/pull/18534#issuecomment-3698400568
@xudong963 perhaps you can take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: implement partition_statistics for WindowAggExec [datafusion]
Posted by "0xPoe (via GitHub)" <gi...@apache.org>.
0xPoe commented on PR #18534:
URL: https://github.com/apache/datafusion/pull/18534#issuecomment-3698976810
I will resolve the conflict later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: implement partition_statistics for WindowAggExec [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 commented on PR #18534:
URL: https://github.com/apache/datafusion/pull/18534#issuecomment-3698726823
Yeah, sorry, I totally missed the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: implement partition_statistics for WindowAggExec [datafusion]
Posted by "0xPoe (via GitHub)" <gi...@apache.org>.
0xPoe commented on code in PR #18534:
URL: https://github.com/apache/datafusion/pull/18534#discussion_r2653888424
##########
datafusion/physical-plan/src/windows/window_agg_exec.rs:
##########
@@ -159,8 +159,8 @@ impl WindowAggExec {
}
}
- fn statistics_inner(&self) -> Result<Statistics> {
- let input_stat = self.input.partition_statistics(None)?;
+ fn statistics_inner(&self, partition: Option<usize>) -> Result<Statistics> {
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: implement partition_statistics for WindowAggExec [datafusion]
Posted by "0xPoe (via GitHub)" <gi...@apache.org>.
0xPoe commented on code in PR #18534:
URL: https://github.com/apache/datafusion/pull/18534#discussion_r2504756278
##########
datafusion/physical-plan/src/windows/window_agg_exec.rs:
##########
@@ -159,8 +159,8 @@ impl WindowAggExec {
}
}
- fn statistics_inner(&self) -> Result<Statistics> {
- let input_stat = self.input.partition_statistics(None)?;
+ fn statistics_inner(&self, partition: Option<usize>) -> Result<Statistics> {
Review Comment:
We may want to move the code directly into the partition_statistics and remove this inner function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: implement partition_statistics for WindowAggExec [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 merged PR #18534:
URL: https://github.com/apache/datafusion/pull/18534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org