You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Apache Spark (JIRA)" <ji...@apache.org> on 2018/09/02 18:03:03 UTC
[jira] [Commented] (AIRFLOW-2504) Airflow UI Auditing - log
username show extra filter
[ https://issues.apache.org/jira/browse/AIRFLOW-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601458#comment-16601458 ]
Apache Spark commented on AIRFLOW-2504:
---------------------------------------
User 'youngyjd' has created a pull request for this issue:
https://github.com/apache/incubator-airflow/pull/3438
> Airflow UI Auditing - log username show extra filter
> ----------------------------------------------------
>
> Key: AIRFLOW-2504
> URL: https://issues.apache.org/jira/browse/AIRFLOW-2504
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Junda Yang
> Assignee: Junda Yang
> Priority: Minor
> Fix For: 2.0.0
>
>
> 1. There is a bug in the [action_logging|https://github.com/apache/incubator-airflow/blob/1f0a717b65e0ea7e0127708b084baff0697f0946/airflow/www/utils.py#L249] of old UI. The *username* attribute is always in *current_user* but it is *None*. We should call *current_user.user.username* to get the username. See example usage of [current_user.user.username|https://github.com/apache/incubator-airflow/blob/1f0a717b65e0ea7e0127708b084baff0697f0946/airflow/www/views.py#L1929]
> 2. We also need to add a column filter on *extra* so we can search for request content, like who send what kind of write request from Airflow UI, as the action_logging is [logging all request parameters|https://github.com/apache/incubator-airflow/blob/1f0a717b65e0ea7e0127708b084baff0697f0946/airflow/www/utils.py#L258] in extra field.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)