You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/04 16:18:57 UTC
[GitHub] [tvm] mbrookhart opened a new pull request #8193: [WIP] Update ONNX versions
mbrookhart opened a new pull request #8193:
URL: https://github.com/apache/tvm/pull/8193
I'm expecting this to fail CI horribly. Will ping reviewers once I get closer to getting it passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #8193:
URL: https://github.com/apache/tvm/pull/8193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r671449150
##########
File path: Jenkinsfile
##########
@@ -45,12 +45,12 @@
// NOTE: these lines are scanned by docker/dev_common.sh. Please update the regex as needed. -->
ci_lint = "tlcpack/ci-lint:v0.66"
-ci_gpu = "tlcpack/ci-gpu:v0.75"
-ci_cpu = "tlcpack/ci-cpu:v0.74"
+ci_gpu = "mbrookhart/ci-gpu:v0.2"
Review comment:
```suggestion
ci_gpu = "tlcpack/ci-gpu:v0.76"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r671505162
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -2686,62 +2691,58 @@ def repeat(N, D):
verify_convtranspose_with_padding(
(1, 1) + repeat(5, D),
(1, 1) + repeat(3, D),
- (1, 1) + repeat(7, D),
2 * repeat(0, D),
repeat(3, D),
repeat(1, D),
repeat(1, D),
)
- # Convolution with autopadding
- verify_convtranspose_with_padding(
- (1, 1) + repeat(5, D),
- (1, 1) + repeat(3, D),
- (1, 1) + repeat(5, D),
- None,
- repeat(3, D),
- repeat(1, D),
- repeat(1, D),
- auto_pad="SAME_UPPER",
- )
- # Convolution with valid autopadding
- verify_convtranspose_with_padding(
- (1, 1) + repeat(5, D),
- (1, 1) + repeat(3, D),
- (1, 1) + repeat(7, D),
- None,
- repeat(3, D),
- repeat(1, D),
- repeat(1, D),
- auto_pad="VALID",
- )
# Convolution with unset padding
verify_convtranspose_with_padding(
(1, 1) + repeat(5, D),
(1, 1) + repeat(3, D),
- (1, 1) + repeat(7, D),
2 * repeat(0, D),
repeat(3, D),
repeat(1, D),
repeat(1, D),
True,
)
- # Convolution with non uniform stride
- verify_convtranspose_with_padding(
- (1, 1) + repeat(5, D),
- (1, 1) + repeat(3, D),
- (1, 1) + repeat(9, D),
- None,
- repeat(3, D),
- repeat(2, D),
- repeat(1, D),
- auto_pad="SAME_UPPER",
- )
+ ## TODO(mbrookhart): renable autopad tests when CI ONNX
Review comment:
per discussion, this will be a follow-on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r671449780
##########
File path: Jenkinsfile
##########
@@ -45,12 +45,12 @@
// NOTE: these lines are scanned by docker/dev_common.sh. Please update the regex as needed. -->
ci_lint = "tlcpack/ci-lint:v0.66"
-ci_gpu = "tlcpack/ci-gpu:v0.75"
-ci_cpu = "tlcpack/ci-cpu:v0.74"
+ci_gpu = "mbrookhart/ci-gpu:v0.2"
+ci_cpu = "mbrookhart/ci-cpu:v0.2"
Review comment:
```suggestion
ci_cpu = "tlcpack/ci-cpu:v0.75"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #8193: [WIP] Update ONNX versions
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#issuecomment-876608644
```
+ echo 'INFO: NODE_NAME=sampl.aladdin.cuda1 EXECUTOR_NUMBER=0'
INFO: NODE_NAME=sampl.aladdin.cuda1 EXECUTOR_NUMBER=0`
```
looks like another SAMPL node @tqchen. do we want to keep this in for diversity of testing or remove it? my vote is to remove it since it is a probabilistic failure scenario rather than a deterministic one. i think our CI is so long that we can't afford to allow code to merge that isn't expected to deterministically pass a following run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#issuecomment-880854733
@mbrookhart I just tested it for both `host` and `mps2` target and it passes. It could be a flaky timeout.
Please re-trigger the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8193: [WIP] Update ONNX versions
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r655774993
##########
File path: docker/install/ubuntu_install_onnx.sh
##########
@@ -20,9 +20,10 @@ set -e
set -u
set -o pipefail
-# fix to certain version for now
-pip3 install onnx==1.6.0
-pip3 install onnxruntime==1.0.0
+# We need to fix the onnx version because changing versions tends to break tests
+# TODO(mbrookhart): periodically update
+pip3 install onnx==1.8.0
Review comment:
ah ignore me, we were constraining this separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8193: [WIP] Update ONNX versions
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r655774993
##########
File path: docker/install/ubuntu_install_onnx.sh
##########
@@ -20,9 +20,10 @@ set -e
set -u
set -o pipefail
-# fix to certain version for now
-pip3 install onnx==1.6.0
-pip3 install onnxruntime==1.0.0
+# We need to fix the onnx version because changing versions tends to break tests
+# TODO(mbrookhart): periodically update
+pip3 install onnx==1.8.0
Review comment:
ah ignore me, we were constraining this separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#issuecomment-882635319
Thanks @areusch @mehrdadh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#issuecomment-882635319
Thanks @areusch @mehrdadh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8193: [WIP] Update ONNX versions
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r654518527
##########
File path: docker/install/ubuntu_install_onnx.sh
##########
@@ -20,9 +20,10 @@ set -e
set -u
set -o pipefail
-# fix to certain version for now
-pip3 install onnx==1.6.0
-pip3 install onnxruntime==1.0.0
+# We need to fix the onnx version because changing versions tends to break tests
+# TODO(mbrookhart): periodically update
+pip3 install onnx==1.8.0
Review comment:
can you also update `python/gen_requirements.py`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on a change in pull request #8193: [WIP] Update ONNX versions
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r654540087
##########
File path: docker/install/ubuntu_install_onnx.sh
##########
@@ -20,9 +20,10 @@ set -e
set -u
set -o pipefail
-# fix to certain version for now
-pip3 install onnx==1.6.0
-pip3 install onnxruntime==1.0.0
+# We need to fix the onnx version because changing versions tends to break tests
+# TODO(mbrookhart): periodically update
+pip3 install onnx==1.8.0
Review comment:
I'm not sure what there is to update? gen_requirements.py doesn't constrain the version of ONNX, and the goal here is to maintain backwards compatibility with old versions of onnx, that's why the importer supports opsets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#issuecomment-882635319
Thanks @areusch @mehrdadh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #8193:
URL: https://github.com/apache/tvm/pull/8193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #8193:
URL: https://github.com/apache/tvm/pull/8193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch removed a comment on pull request #8193: [WIP] Update ONNX versions
Posted by GitBox <gi...@apache.org>.
areusch removed a comment on pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#issuecomment-876608644
```
+ echo 'INFO: NODE_NAME=sampl.aladdin.cuda1 EXECUTOR_NUMBER=0'
INFO: NODE_NAME=sampl.aladdin.cuda1 EXECUTOR_NUMBER=0`
```
looks like another SAMPL node @tqchen. do we want to keep this in for diversity of testing or remove it? my vote is to remove it since it is a probabilistic failure scenario rather than a deterministic one. i think our CI is so long that we can't afford to allow code to merge that isn't expected to deterministically pass a following run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r671451818
##########
File path: Jenkinsfile
##########
@@ -45,12 +45,12 @@
// NOTE: these lines are scanned by docker/dev_common.sh. Please update the regex as needed. -->
ci_lint = "tlcpack/ci-lint:v0.66"
-ci_gpu = "tlcpack/ci-gpu:v0.75"
-ci_cpu = "tlcpack/ci-cpu:v0.74"
+ci_gpu = "mbrookhart/ci-gpu:v0.2"
+ci_cpu = "mbrookhart/ci-cpu:v0.2"
ci_wasm = "tlcpack/ci-wasm:v0.71"
ci_i386 = "tlcpack/ci-i386:v0.73"
-ci_qemu = "tlcpack/ci-qemu:v0.05"
-ci_arm = "tlcpack/ci-arm:v0.05"
+ci_qemu = "mbrookhart/ci-qemu:v0.2"
+ci_arm = "areusch1/ci-arm-staging:v0.05"
Review comment:
```suggestion
ci_arm = "tlcpack/ci-arm:v0.06"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8193: Update Docker CI
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r671450326
##########
File path: Jenkinsfile
##########
@@ -45,12 +45,12 @@
// NOTE: these lines are scanned by docker/dev_common.sh. Please update the regex as needed. -->
ci_lint = "tlcpack/ci-lint:v0.66"
-ci_gpu = "tlcpack/ci-gpu:v0.75"
-ci_cpu = "tlcpack/ci-cpu:v0.74"
+ci_gpu = "mbrookhart/ci-gpu:v0.2"
+ci_cpu = "mbrookhart/ci-cpu:v0.2"
ci_wasm = "tlcpack/ci-wasm:v0.71"
ci_i386 = "tlcpack/ci-i386:v0.73"
-ci_qemu = "tlcpack/ci-qemu:v0.05"
-ci_arm = "tlcpack/ci-arm:v0.05"
+ci_qemu = "mbrookhart/ci-qemu:v0.2"
Review comment:
```suggestion
ci_qemu = "tlcpack/ci-qemu:v0.06"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org