You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/05/21 17:36:00 UTC

[kudu-CR](branch-1.7.x) [kudu CLI] KUDU-2443 fix replica movement for RF=1

Hello Mike Percy, Kudu Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10467

to review the following change.


Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................

[kudu CLI] KUDU-2443 fix replica movement for RF=1

During replica replacement, if the leader replica is being replaced,
do not ask it to step down until the newly added replica transitions
into a voter role.  Otherwise, that might prevent tablet copying to
finish successfully under racy conditions in case of replication
factor of 1.

The workaround described above works OK for the case of moving/replacing
replicas in the context of KUDU-2443. The core of the underlying issue
will be addressed separately: see KUDU-2446 for details.

This changelist also contains a small clean-up in tool_action_tablet.cc
(the clean-up itself does not contain any functional changes).

Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Reviewed-on: http://gerrit.cloudera.org:8080/10439
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit b73dec1e4975843a434cb84ab618aabedbfaa3b2)
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 28 insertions(+), 15 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/10467/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](branch-1.7.x) [kudu CLI] KUDU-2443 fix replica movement for RF=1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/10467 )

Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/10467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR](branch-1.7.x) [kudu CLI] KUDU-2443 fix replica movement for RF=1

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10467 )

Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 21 May 2018 17:38:08 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.7.x) [kudu CLI] KUDU-2443 fix replica movement for RF=1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10467 )

Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................


Patch Set 1: Verified+1

unrelated flakiness in:

    DeleteTableITest.TestNoDeleteTombstonedTablets
    DeleteTableITest.TestNoDeleteTombstonedTablets
    AdminCliTest.TestUnsafeChangeConfigWithMultiplePendingConfigs


-- 
To view, visit http://gerrit.cloudera.org:8080/10467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 21 May 2018 19:36:15 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.7.x) [kudu CLI] KUDU-2443 fix replica movement for RF=1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10467 )

Change subject: [kudu CLI] KUDU-2443 fix replica movement for RF=1
......................................................................

[kudu CLI] KUDU-2443 fix replica movement for RF=1

During replica replacement, if the leader replica is being replaced,
do not ask it to step down until the newly added replica transitions
into a voter role.  Otherwise, that might prevent tablet copying to
finish successfully under racy conditions in case of replication
factor of 1.

The workaround described above works OK for the case of moving/replacing
replicas in the context of KUDU-2443. The core of the underlying issue
will be addressed separately: see KUDU-2446 for details.

This changelist also contains a small clean-up in tool_action_tablet.cc
(the clean-up itself does not contain any functional changes).

Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Reviewed-on: http://gerrit.cloudera.org:8080/10439
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit b73dec1e4975843a434cb84ab618aabedbfaa3b2)
Reviewed-on: http://gerrit.cloudera.org:8080/10467
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/tool_action_tablet.cc
1 file changed, 28 insertions(+), 15 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I59ce249ae4e3bbcf42d8d754c68d1b92ab93f287
Gerrit-Change-Number: 10467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>