You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-commits@incubator.apache.org by "Jan Matèrne (JIRA)" <ji...@apache.org> on 2007/04/26 09:38:15 UTC

[jira] Created: (IVY-483) Tool support for checking code

Tool support for checking code
------------------------------

                 Key: IVY-483
                 URL: https://issues.apache.org/jira/browse/IVY-483
             Project: Ivy
          Issue Type: Improvement
            Reporter: Jan Matèrne
            Priority: Minor


You should use tools like Checkstyle, PMD and Findbugs for checking the code for possible errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (IVY-483) Tool support for checking code

Posted by "Jan Matèrne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Matèrne updated IVY-483:
----------------------------

    Attachment: patch.zip

Patch-Zip-File with files based on Ant's checks ...

check.xml
* Ant buildfile starting the Checks.
* Requires: Checkstyle, Xalan, Simian
* property "check.tools.dir" must point to a directory containing
  -- Checkstyle: checkstyle-all-4.3.jar
  -- Simian: simian-2.2.17.jar
  -- Xalan (2.7.0): xalan.jar, serializer.jar

checkstyle-config
* Configuration file for Checkstyle, activates Checkstyle-Simian addin
* need customization for Ivy

checkstyle-*.xsl
* XSLTs for generating HTML, Text and XDoc files from raw xml (same as in Ant)

RequiredHeader.txt
* ASF2.0 license header which must at the beginning of ASF Java files (same as in Ant)


> Tool support for checking code
> ------------------------------
>
>                 Key: IVY-483
>                 URL: https://issues.apache.org/jira/browse/IVY-483
>             Project: Ivy
>          Issue Type: Improvement
>            Reporter: Jan Matèrne
>            Priority: Minor
>         Attachments: patch.zip
>
>
> You should use tools like Checkstyle, PMD and Findbugs for checking the code for possible errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (IVY-483) Tool support for checking code

Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/IVY-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498408 ] 

Maarten Coene commented on IVY-483:
-----------------------------------

I've integrated your patch (modified it a bit here and there).
I'm not closing it yet because we need to review the checkstyle configuration

> Tool support for checking code
> ------------------------------
>
>                 Key: IVY-483
>                 URL: https://issues.apache.org/jira/browse/IVY-483
>             Project: Ivy
>          Issue Type: Improvement
>            Reporter: Jan Matèrne
>         Assigned To: Maarten Coene
>            Priority: Minor
>         Attachments: patch.zip
>
>
> You should use tools like Checkstyle, PMD and Findbugs for checking the code for possible errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (IVY-483) Tool support for checking code

Posted by "Jan Matèrne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/IVY-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498491 ] 

Jan Matèrne commented on IVY-483:
---------------------------------

Sure - the patch was intended to be modified. But its less work to modify than to implement a complete new one ;-)

And it's cool to the how Ivy deals with the <taskdef> ...


<ivy:cachepath 
    organisation="checkstyle" module="checkstyle" revision="4.3" 
    inline="true" conf="default" 
    pathid="checkstyle.classpath" transitive="true"
/> 
<taskdef resource="checkstyletask.properties" classpathref="checkstyle.classpath" />



Do you have seen the TODO statement in the configuration file? Maybe you want to load Simian too ....

> Tool support for checking code
> ------------------------------
>
>                 Key: IVY-483
>                 URL: https://issues.apache.org/jira/browse/IVY-483
>             Project: Ivy
>          Issue Type: Improvement
>            Reporter: Jan Matèrne
>         Assigned To: Maarten Coene
>            Priority: Minor
>         Attachments: patch.zip
>
>
> You should use tools like Checkstyle, PMD and Findbugs for checking the code for possible errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (IVY-483) Tool support for checking code

Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/IVY-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maarten Coene reassigned IVY-483:
---------------------------------

    Assignee: Maarten Coene

> Tool support for checking code
> ------------------------------
>
>                 Key: IVY-483
>                 URL: https://issues.apache.org/jira/browse/IVY-483
>             Project: Ivy
>          Issue Type: Improvement
>            Reporter: Jan Matèrne
>         Assigned To: Maarten Coene
>            Priority: Minor
>         Attachments: patch.zip
>
>
> You should use tools like Checkstyle, PMD and Findbugs for checking the code for possible errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (IVY-483) Tool support for checking code

Posted by "Xavier Hanin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/IVY-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495590 ] 

Xavier Hanin commented on IVY-483:
----------------------------------

Thanks a lot for this contribution! For the required jars, I suggest we use a little tool called Ivy to download them automatically :-)

> Tool support for checking code
> ------------------------------
>
>                 Key: IVY-483
>                 URL: https://issues.apache.org/jira/browse/IVY-483
>             Project: Ivy
>          Issue Type: Improvement
>            Reporter: Jan Matèrne
>            Priority: Minor
>         Attachments: patch.zip
>
>
> You should use tools like Checkstyle, PMD and Findbugs for checking the code for possible errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.