You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/03/08 00:48:06 UTC
[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6310
Change subject: IMPALA-5025: upgrade to binutils 2.26.1
......................................................................
IMPALA-5025: upgrade to binutils 2.26.1
This has two fixes that we care about:
* The slow linking problem that the -p1 patch to 2.26 solved
* A way to disable emitting relocations R_X86_64_GOTPCRELX and
R_X86_64_REX_GOTPCRELX that aren't supported by older linkers.
We configure binutils to disable these by default to be as safe
as possible.
Testing:
Built Impala locally with 2.26-p1 and 2.26.1 and inspected
libImpalaUdf.a with objdump -x to make sure that the relocation
types changed to ensure that the change had an effect.
Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
---
M init.sh
M source/binutils/build.sh
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/10/6310/1
--
To view, visit http://gerrit.cloudera.org:8080/6310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.11.0
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5025: upgrade to binutils 2.26.1
......................................................................
Patch Set 1:
I'm building it as we speak
--
To view, visit http://gerrit.cloudera.org:8080/6310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.11.0
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5025: upgrade to binutils 2.26.1
......................................................................
Patch Set 1: Code-Review+2
Have you tested this builds correctly on this branch (as opposed to master) ?
--
To view, visit http://gerrit.cloudera.org:8080/6310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.11.0
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5025: upgrade to binutils 2.26.1
......................................................................
Patch Set 1: Verified+1
Build ID 364-1b266466ae
--
To view, visit http://gerrit.cloudera.org:8080/6310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.11.0
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-5025: upgrade to binutils 2.26.1
......................................................................
IMPALA-5025: upgrade to binutils 2.26.1
This has two fixes that we care about:
* The slow linking problem that the -p1 patch to 2.26 solved
* A way to disable emitting relocations R_X86_64_GOTPCRELX and
R_X86_64_REX_GOTPCRELX that aren't supported by older linkers.
We configure binutils to disable these by default to be as safe
as possible.
Testing:
Built Impala locally with 2.26-p1 and 2.26.1 and inspected
libImpalaUdf.a with objdump -x to make sure that the relocation
types changed to ensure that the change had an effect.
Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
---
M init.sh
M source/binutils/build.sh
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Matthew Jacobs: Looks good to me, approved
Tim Armstrong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.11.0
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>