You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2009/12/29 01:54:29 UTC
[jira] Created: (THRIFT-665) Lots of C++ changes developed at
Facebook
Lots of C++ changes developed at Facebook
-----------------------------------------
Key: THRIFT-665
URL: https://issues.apache.org/jira/browse/THRIFT-665
Project: Thrift
Issue Type: Improvement
Components: Library (C++)
Reporter: David Reiss
Attachments: all-cpp-diffs.patch
We've got a bunch of changes that were made at Facebook that we'd like to merge back into Apache Thrift. The changes can be broadly broken down into:
- Scalability improvements for TNonBlockingServer
- New features for concurrency library
- Minor internal usability improvments
- Minor bug fixes
- Minor optimizations
I'll attach a single big patch, and the individual commits are visible at http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD
Let me know if you want these changes made available in some other format. My preference would be to just go ahead and commit these one at a time, but I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-665) Lots of C++ changes developed at
Facebook
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842530#action_12842530 ]
David Reiss commented on THRIFT-665:
------------------------------------
Anyone mind if I check these in?
> Lots of C++ changes developed at Facebook
> -----------------------------------------
>
> Key: THRIFT-665
> URL: https://issues.apache.org/jira/browse/THRIFT-665
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: David Reiss
> Attachments: all-cpp-diffs.patch
>
>
> We've got a bunch of changes that were made at Facebook that we'd like to merge back into Apache Thrift. The changes can be broadly broken down into:
> - Scalability improvements for TNonBlockingServer
> - New features for concurrency library
> - Minor internal usability improvments
> - Minor bug fixes
> - Minor optimizations
> I'll attach a single big patch, and the individual commits are visible at http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD
> Let me know if you want these changes made available in some other format. My preference would be to just go ahead and commit these one at a time, but I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-665) Lots of C++ changes developed at
Facebook
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795180#action_12795180 ]
Doug Cutting commented on THRIFT-665:
-------------------------------------
> My preference would be to just go ahead and commit these one at a time [ ... ]
Perhaps they should each be separate Jira issues, each available for independent review by the community?
> Lots of C++ changes developed at Facebook
> -----------------------------------------
>
> Key: THRIFT-665
> URL: https://issues.apache.org/jira/browse/THRIFT-665
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: David Reiss
> Attachments: all-cpp-diffs.patch
>
>
> We've got a bunch of changes that were made at Facebook that we'd like to merge back into Apache Thrift. The changes can be broadly broken down into:
> - Scalability improvements for TNonBlockingServer
> - New features for concurrency library
> - Minor internal usability improvments
> - Minor bug fixes
> - Minor optimizations
> I'll attach a single big patch, and the individual commits are visible at http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD
> Let me know if you want these changes made available in some other format. My preference would be to just go ahead and commit these one at a time, but I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-665) Lots of C++ changes developed at
Facebook
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-665.
--------------------------------
Resolution: Fixed
Committed revs 920664-920691
> Lots of C++ changes developed at Facebook
> -----------------------------------------
>
> Key: THRIFT-665
> URL: https://issues.apache.org/jira/browse/THRIFT-665
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: David Reiss
> Attachments: all-cpp-diffs.patch
>
>
> We've got a bunch of changes that were made at Facebook that we'd like to merge back into Apache Thrift. The changes can be broadly broken down into:
> - Scalability improvements for TNonBlockingServer
> - New features for concurrency library
> - Minor internal usability improvments
> - Minor bug fixes
> - Minor optimizations
> I'll attach a single big patch, and the individual commits are visible at http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD
> Let me know if you want these changes made available in some other format. My preference would be to just go ahead and commit these one at a time, but I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-665) Lots of C++ changes developed at
Facebook
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-665:
-------------------------------
Attachment: all-cpp-diffs.patch
> Lots of C++ changes developed at Facebook
> -----------------------------------------
>
> Key: THRIFT-665
> URL: https://issues.apache.org/jira/browse/THRIFT-665
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: David Reiss
> Attachments: all-cpp-diffs.patch
>
>
> We've got a bunch of changes that were made at Facebook that we'd like to merge back into Apache Thrift. The changes can be broadly broken down into:
> - Scalability improvements for TNonBlockingServer
> - New features for concurrency library
> - Minor internal usability improvments
> - Minor bug fixes
> - Minor optimizations
> I'll attach a single big patch, and the individual commits are visible at http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD
> Let me know if you want these changes made available in some other format. My preference would be to just go ahead and commit these one at a time, but I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-665) Lots of C++ changes developed at
Facebook
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795199#action_12795199 ]
Bryan Duxbury commented on THRIFT-665:
--------------------------------------
I'm pretty sure we discussed the bulk submission approach on the mailing list and we were OK with it.
> Lots of C++ changes developed at Facebook
> -----------------------------------------
>
> Key: THRIFT-665
> URL: https://issues.apache.org/jira/browse/THRIFT-665
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: David Reiss
> Attachments: all-cpp-diffs.patch
>
>
> We've got a bunch of changes that were made at Facebook that we'd like to merge back into Apache Thrift. The changes can be broadly broken down into:
> - Scalability improvements for TNonBlockingServer
> - New features for concurrency library
> - Minor internal usability improvments
> - Minor bug fixes
> - Minor optimizations
> I'll attach a single big patch, and the individual commits are visible at http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD
> Let me know if you want these changes made available in some other format. My preference would be to just go ahead and commit these one at a time, but I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-665) Lots of C++ changes developed at
Facebook
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795182#action_12795182 ]
David Reiss commented on THRIFT-665:
------------------------------------
Well, it's 28 patches, most of which are extremely short and boring. I'm more than happy to write a script to post each one to its own issue if an actual human is interested in reading them.
> Lots of C++ changes developed at Facebook
> -----------------------------------------
>
> Key: THRIFT-665
> URL: https://issues.apache.org/jira/browse/THRIFT-665
> Project: Thrift
> Issue Type: Improvement
> Components: Library (C++)
> Reporter: David Reiss
> Attachments: all-cpp-diffs.patch
>
>
> We've got a bunch of changes that were made at Facebook that we'd like to merge back into Apache Thrift. The changes can be broadly broken down into:
> - Scalability improvements for TNonBlockingServer
> - New features for concurrency library
> - Minor internal usability improvments
> - Minor bug fixes
> - Minor optimizations
> I'll attach a single big patch, and the individual commits are visible at http://gitweb.thrift-rpc.org/?p=thrift.git;a=log;h=refs/heads/pri/dreiss/fb-merge-p1;hb=HEAD
> Let me know if you want these changes made available in some other format. My preference would be to just go ahead and commit these one at a time, but I'm open to suggestions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.