You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/11/28 22:09:43 UTC
[GitHub] [systemds] j143 opened a new pull request #1468: [DOC] Add instructions for download R dependencies
j143 opened a new pull request #1468:
URL: https://github.com/apache/systemds/pull/1468
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1468: [DOC] Add instructions for download R dependencies
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #1468:
URL: https://github.com/apache/systemds/pull/1468#issuecomment-981170834
Why an user needs to install R?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1468: [DOC] Add instructions for download R dependencies
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #1468:
URL: https://github.com/apache/systemds/pull/1468#issuecomment-981369775
If I am not wrong, the current doc doesn't tell how to build the test classes. And that is because the primary target is the users who want to build SystemDS from the source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1468: [DOC] Add instructions for download R dependencies
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1468:
URL: https://github.com/apache/systemds/pull/1468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1468: [DOC] Add instructions for download R dependencies
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1468:
URL: https://github.com/apache/systemds/pull/1468#issuecomment-981343270
> Why an user needs to install R?
This doc is also, helpful for developers. (intent of this is for systemds developers too!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1468: [DOC] Add instructions for download R dependencies
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1468:
URL: https://github.com/apache/systemds/pull/1468#issuecomment-981573379
> If I am not wrong, the current doc doesn't tell how to build the test classes. And that is because the primary target is the users who want to build SystemDS from the source.
I agree with this statement, for the devs we should do an extended guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on a change in pull request #1468: [DOC] Add instructions for download R dependencies
Posted by GitBox <gi...@apache.org>.
j143 commented on a change in pull request #1468:
URL: https://github.com/apache/systemds/pull/1468#discussion_r758082398
##########
File path: docs/site/install.md
##########
@@ -127,6 +134,13 @@ export JAVA_HOME=`/usr/libexec/java_home -v 1.8`
For running all tests [r-base](https://cran.r-project.org/bin/macosx/) has to be installed as well since this is used as a secondary system to verify the correctness of our code, but it is not a requirement to enable building the project.
+Additionally, you need to install the R depedencies for integration tests, like this:
Review comment:
```suggestion
Optionally, you need to install the R depedencies for integration tests, like this:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on a change in pull request #1468: [DOC] Add instructions for download R dependencies
Posted by GitBox <gi...@apache.org>.
j143 commented on a change in pull request #1468:
URL: https://github.com/apache/systemds/pull/1468#discussion_r758082149
##########
File path: docs/site/install.md
##########
@@ -83,6 +83,13 @@ sudo add-apt-repository 'deb https://cloud.r-project.org/bin/linux/ubuntu focal-
sudo apt install r-base
```
+Additionally, you need to install the R depedencies for integration tests, like this:
Review comment:
```suggestion
Optionally, you need to install the R depedencies for integration tests, like this:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org