[GitHub] ivankelly commented on a change in pull request #1217: Shade bookkeeper in distributedlog-core-shaded and allow using shaded bookkeeper client to resolve ledger manager factory class

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #1217:  Shade bookkeeper in distributedlog-core-shaded and allow using shaded bookkeeper client to resolve ledger manager factory class
URL: https://github.com/apache/bookkeeper/pull/1217#discussion_r171212442
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
 ##########
 @@ -310,6 +312,60 @@ public String getLedgerManagerType() {
         return getString(LEDGER_MANAGER_TYPE);
     }
 
+    /**
+     * Set the flag to allow using shaded ledger manager factory class for
+     * instantiating a ledger manager factory.
+     *
+     * @param allowed
+     *          the flag to allow/disallow using shaded ledger manager factory class
+     * @return configuration instance.
+     */
+    public T setAllowShadedLedgerManagerFactoryClass(boolean allowed) {
 
 Review comment:
   I don't think this is needed. If you set "ShadedLedgerManagerFactoryClassPrefix" it implies you want to allow it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services