You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2013/12/09 12:05:00 UTC

Review Request 16127: Fixed CLOUDSTACK-5411

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16127/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5411
    https://issues.apache.org/jira/browse/CLOUDSTACK-5411


Repository: cloudstack-git


Description
-------

1. Currently, there was an issue with logging formatter under marvin. Proper format messages are not getting printed. Fixed that.
    
2. There were few references in existing cfg files for earlier used logger node. Removed them and added new logger node as part of pending clean up.
    
3. Added TC information started, flow and the result accordingly to runlog. This will simplify to see the test case starting , sequence of steps and final result including timestamps for test c
    
4. Added few changes to dump the exception throwing tc's to the explicit exception file.


Diffs
-----

  tools/marvin/marvin/misc/build/CI.md PRE-CREATION 
  tools/marvin/marvin/misc/build/README.md PRE-CREATION 
  tools/marvin/marvin/misc/build/advanced_env.py PRE-CREATION 
  tools/marvin/marvin/misc/build/asf_test.cfg PRE-CREATION 
  tools/marvin/marvin/misc/build/bashUtils.py PRE-CREATION 
  tools/marvin/marvin/misc/build/buildGenerator.py PRE-CREATION 
  tools/marvin/marvin/misc/build/configure.py PRE-CREATION 
  tools/marvin/marvin/misc/build/hudson.sh PRE-CREATION 
  tools/marvin/marvin/misc/build/kvm.cfg PRE-CREATION 
  tools/marvin/marvin/misc/build/kvm.properties PRE-CREATION 
  tools/marvin/marvin/misc/build/openport.py PRE-CREATION 
  tools/marvin/marvin/misc/build/redeploy.sh PRE-CREATION 
  tools/marvin/marvin/misc/build/restartMgmt.py PRE-CREATION 
  tools/marvin/marvin/misc/build/system.properties PRE-CREATION 
  tools/marvin/marvin/misc/build/testSetupSuccess.py PRE-CREATION 
  tools/marvin/marvin/misc/build/vm-start.sh PRE-CREATION 
  tools/marvin/marvin/misc/build/vm-uninstall.sh PRE-CREATION 
  tools/marvin/marvin/misc/build/xen.cfg PRE-CREATION 
  tools/marvin/marvin/misc/build/xen.properties PRE-CREATION 
  tools/marvin/marvin/misc/build/xunitmp/setup.py PRE-CREATION 
  tools/marvin/marvin/misc/build/xunitmp/xunitmultiprocess.py PRE-CREATION 

Diff: https://reviews.apache.org/r/16127/diff/


Testing
-------

Tested running basic sanity post changes.


Thanks,

Santhosh Edukulla


Re: Review Request 16127: Fixed CLOUDSTACK-5411

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16127/#review30009
-----------------------------------------------------------

Ship it!


COmmitted to 4.2, 4.3 and master.

- Girish Shilamkar


On Dec. 9, 2013, 11:17 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16127/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2013, 11:17 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5411
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5411
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Currently, there was an issue with logging formatter under marvin. Proper format messages are not getting printed. Fixed that.
>     
> 2. There were few references in existing cfg files for earlier used logger node. Removed them and added new logger node as part of pending clean up.
>     
> 3. Added TC information started, flow and the result accordingly to runlog. This will simplify to see the test case starting , sequence of steps and final result including timestamps for test c
>     
> 4. Added few changes to dump the exception throwing tc's to the explicit exception file.
> 
> 
> Diffs
> -----
> 
>   setup/dev/advancedsg.cfg c6a1f59 
>   setup/dev/basic.cfg e91c87a 
>   tools/devcloud/devcloud.cfg e209b55 
>   tools/marvin/marvin/codes.py 8f0f88d 
>   tools/marvin/marvin/config/setup.cfg 216314f 
>   tools/marvin/marvin/marvinInit.py d822a2b 
>   tools/marvin/marvin/marvinLog.py ca4d600 
>   tools/marvin/marvin/marvinPlugin.py f5b7a88 
> 
> Diff: https://reviews.apache.org/r/16127/diff/
> 
> 
> Testing
> -------
> 
> Tested running basic sanity post changes.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Re: Review Request 16127: Fixed CLOUDSTACK-5411

Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16127/
-----------------------------------------------------------

(Updated Dec. 9, 2013, 11:17 a.m.)


Review request for cloudstack and Girish Shilamkar.


Changes
-------

Added correct patch


Bugs: CLOUDSTACK-5411
    https://issues.apache.org/jira/browse/CLOUDSTACK-5411


Repository: cloudstack-git


Description
-------

1. Currently, there was an issue with logging formatter under marvin. Proper format messages are not getting printed. Fixed that.
    
2. There were few references in existing cfg files for earlier used logger node. Removed them and added new logger node as part of pending clean up.
    
3. Added TC information started, flow and the result accordingly to runlog. This will simplify to see the test case starting , sequence of steps and final result including timestamps for test c
    
4. Added few changes to dump the exception throwing tc's to the explicit exception file.


Diffs (updated)
-----

  setup/dev/advancedsg.cfg c6a1f59 
  setup/dev/basic.cfg e91c87a 
  tools/devcloud/devcloud.cfg e209b55 
  tools/marvin/marvin/codes.py 8f0f88d 
  tools/marvin/marvin/config/setup.cfg 216314f 
  tools/marvin/marvin/marvinInit.py d822a2b 
  tools/marvin/marvin/marvinLog.py ca4d600 
  tools/marvin/marvin/marvinPlugin.py f5b7a88 

Diff: https://reviews.apache.org/r/16127/diff/


Testing
-------

Tested running basic sanity post changes.


Thanks,

Santhosh Edukulla