You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/07/02 01:12:03 UTC

(superset) branch codex/fix-create-dataset-e2e-timeout created (now cbbf7e4cd4f)

This is an automated email from the ASF dual-hosted git repository.

sadpandajoe pushed a change to branch codex/fix-create-dataset-e2e-timeout
in repository https://gitbox.apache.org/repos/asf/superset.git


      at cbbf7e4cd4f test(ci): stabilize master checks

This branch includes the following new commits:

     new cbbf7e4cd4f test(ci): stabilize master checks

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: test(ci): stabilize master checks

Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

sadpandajoe pushed a commit to branch codex/fix-create-dataset-e2e-timeout
in repository https://gitbox.apache.org/repos/asf/superset.git

commit cbbf7e4cd4f935277dd991f1b6a75d15b05ba5e2
Author: Joe Li <jo...@preset.io>
AuthorDate: Wed Jul 1 18:11:25 2026 -0700

    test(ci): stabilize master checks
---
 .../playwright/tests/dataset/create-dataset.spec.ts              | 3 ++-
 .../mcp_service/dashboard/tool/test_get_dashboard_datasets.py    | 9 +++++++--
 tests/unit_tests/pandas_postprocessing/test_prophet.py           | 7 ++++---
 tests/unit_tests/semantic_layers/mapper_test.py                  | 6 ++++--
 4 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/superset-frontend/playwright/tests/dataset/create-dataset.spec.ts b/superset-frontend/playwright/tests/dataset/create-dataset.spec.ts
index 7dcfa81dd61..52368478d5f 100644
--- a/superset-frontend/playwright/tests/dataset/create-dataset.spec.ts
+++ b/superset-frontend/playwright/tests/dataset/create-dataset.spec.ts
@@ -29,6 +29,7 @@ import { waitForPost } from '../../helpers/api/intercepts';
 import { expectStatusOneOf } from '../../helpers/api/assertions';
 import { getDatabaseByName } from '../../helpers/api/database';
 import { apiExecuteSql } from '../../helpers/api/sqllab';
+import { TIMEOUT } from '../../utils/constants';
 
 interface ExamplesSetupResult {
   tableName: string;
@@ -116,7 +117,7 @@ async function dropTempTable(
 // Uses test.describe only because Playwright's serial mode API requires it -
 // (Deviation from "avoid describe" guideline is necessary for functional reasons)
 test.describe('create dataset wizard', () => {
-  test.describe.configure({ mode: 'serial' });
+  test.describe.configure({ mode: 'serial', timeout: TIMEOUT.SLOW_TEST });
 
   test('should create a dataset via wizard', async ({ page, testAssets }) => {
     const { tableName, dbId, createDatasetPage } = await setupExamplesDataset(
diff --git a/tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py b/tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py
index 10ce19b3112..7c6fc4dbf51 100644
--- a/tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py
+++ b/tests/unit_tests/mcp_service/dashboard/tool/test_get_dashboard_datasets.py
@@ -17,6 +17,7 @@
 
 """Unit tests for the MCP get_dashboard_datasets tool."""
 
+from importlib import import_module
 from unittest.mock import Mock, patch
 
 import pytest
@@ -29,6 +30,10 @@ from superset.mcp_service.utils.sanitization import (
 )
 from superset.utils import json
 
+get_dashboard_datasets_module = import_module(
+    "superset.mcp_service.dashboard.tool.get_dashboard_datasets"
+)
+
 
 def _wrapped(value: str) -> str:
     return f"{LLM_CONTEXT_OPEN_DELIMITER}\n{value}\n{LLM_CONTEXT_CLOSE_DELIMITER}"
@@ -142,8 +147,8 @@ def mock_dataset_access():
 @pytest.fixture(autouse=True)
 def allow_data_model_metadata():
     """Keep tests in the metadata-allowed path unless a test overrides it."""
-    with patch(
-        "superset.mcp_service.dashboard.tool.get_dashboard_datasets."
+    with patch.object(
+        get_dashboard_datasets_module,
         "user_can_view_data_model_metadata",
         return_value=True,
     ) as mock_allow:
diff --git a/tests/unit_tests/pandas_postprocessing/test_prophet.py b/tests/unit_tests/pandas_postprocessing/test_prophet.py
index c87c3790a95..a9c751c15a3 100644
--- a/tests/unit_tests/pandas_postprocessing/test_prophet.py
+++ b/tests/unit_tests/pandas_postprocessing/test_prophet.py
@@ -15,6 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 from datetime import datetime
+from importlib import import_module
 from importlib.util import find_spec
 from unittest.mock import patch
 
@@ -26,6 +27,8 @@ from superset.utils.core import DTTM_ALIAS
 from superset.utils.pandas_postprocessing import prophet
 from tests.unit_tests.fixtures.dataframes import prophet_df
 
+prophet_module = import_module("superset.utils.pandas_postprocessing.prophet")
+
 
 def test_prophet_valid():
     df = prophet(df=prophet_df, time_grain="P1M", periods=3, confidence_interval=0.9)
@@ -207,9 +210,7 @@ def test_prophet_fit_error():
     if find_spec("prophet") is None:
         pytest.skip("prophet not installed")
 
-    with patch(
-        "superset.utils.pandas_postprocessing.prophet._prophet_fit_and_predict"
-    ) as mock_fit:
+    with patch.object(prophet_module, "_prophet_fit_and_predict") as mock_fit:
         mock_fit.side_effect = InvalidPostProcessingError(
             "Unable to generate forecast: Dataframe has fewer than 2 non-NaN rows."
         )
diff --git a/tests/unit_tests/semantic_layers/mapper_test.py b/tests/unit_tests/semantic_layers/mapper_test.py
index 0cbb59c8430..aea381191e3 100644
--- a/tests/unit_tests/semantic_layers/mapper_test.py
+++ b/tests/unit_tests/semantic_layers/mapper_test.py
@@ -2983,8 +2983,9 @@ def test_coerce_integer_rejects_non_integer_float() -> None:
 
 
 def test_coerce_integer_rejects_other_types() -> None:
+    raw: Any = [1]
     with pytest.raises(ValueError, match="Invalid integer value"):
-        _coerce_scalar_filter_value([1], _dim(pa.int64()))
+        _coerce_scalar_filter_value(raw, _dim(pa.int64()))
 
 
 @pytest.mark.parametrize(
@@ -3008,8 +3009,9 @@ def test_coerce_floating_invalid_string_raises() -> None:
 
 
 def test_coerce_floating_rejects_other_types() -> None:
+    raw: Any = [1.0]
     with pytest.raises(ValueError, match="Invalid numeric value"):
-        _coerce_scalar_filter_value([1.0], _dim(pa.float64()))
+        _coerce_scalar_filter_value(raw, _dim(pa.float64()))
 
 
 def test_coerce_date_from_datetime() -> None: