[GitHub] [iceberg] dramaticlly commented on a diff in pull request #6574: Python: Raise exception on deletes

[GitBox <gi...@apache.org>]

dramaticlly commented on code in PR #6574:
URL: https://github.com/apache/iceberg/pull/6574#discussion_r1070176238


##########
python/pyiceberg/table/__init__.py:
##########
@@ -341,7 +346,18 @@ def plan_files(self) -> Iterator[FileScanTask]:
             all_files = files(io.new_input(manifest.manifest_path))
             matching_partition_files = filter(partition_filter, all_files)
 
-            yield from (FileScanTask(file) for file in matching_partition_files)
+            def _check_content(file: ManifestFile) -> ManifestFile:
+                try:
+                    if file.content == ManifestContent.DELETES:
+                        raise ValueError("PyIceberg does not support deletes: https://github.com/apache/iceberg/issues/6568")

Review Comment:
   shall we have a test to cover this ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org