You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/20 09:04:57 UTC

[GitHub] [airflow-client-python] er1shivam opened a new pull request #30: Issue #27 : Fixed dag details to accept None type for dag_run_timeout

er1shivam opened a new pull request #30:
URL: https://github.com/apache/airflow-client-python/pull/30


   Fix for [Issue 27:](https://github.com/apache/airflow-client-python/issues/27)
   
   The `dag_run_timeout` in `dag_details` need to accept None type as its parameter type, because `dag_run_timeout` is an optional parameter on [DAG API](https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/models/dag/index.html#airflow.models.dag.DAG). So , most of the times this parameter will be None whenever no one is specifically mentioning it in their dags.
   
   
   And It is also clearly mentioned in the definition [here](https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/models/dag/index.html#airflow.models.dag.DAG). Small extract..
   `....max_active_runs: int = conf.getint('core', 'max_active_runs_per_dag'), 
   dagrun_timeout: Optional[timedelta] = None,sla_miss_callback: Optional[Callable] = None,..`
   
   
   So , we need to update this params to accept None type as well. Tested it on multiple dags after updating this and it worked fine.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-client-python] houqp commented on pull request #30: Issue #27 : Fixed dag details to accept None type for dag_run_timeout

Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #30:
URL: https://github.com/apache/airflow-client-python/pull/30#issuecomment-917888496


   Hi @er1shivam these code are auto generated using openapi-generator. So you need to fix it in the openapi spec or openapi-generator code base instead, then come back to regenerate the client code in this repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-client-python] msumit closed pull request #30: Issue #27 : Fixed dag details to accept None type for dag_run_timeout

Posted by GitBox <gi...@apache.org>.
msumit closed pull request #30:
URL: https://github.com/apache/airflow-client-python/pull/30


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow-client-python] er1shivam commented on pull request #30: Issue #27 : Fixed dag details to accept None type for dag_run_timeout

Posted by GitBox <gi...@apache.org>.
er1shivam commented on pull request #30:
URL: https://github.com/apache/airflow-client-python/pull/30#issuecomment-920212431


   Thanks @houqp . I will make the changes as required and raise a PR again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org