[jira] [Commented] (YARN-5219) When an export var command fails in launch_container.sh, the full container launch should fail

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400848#comment-15400848 ] 

Allen Wittenauer commented on YARN-5219:
----------------------------------------

bq. Any shell variable substitution with empty value can be considered as error

Why?  It's perfectly valid to have a env var that exists but is empty.

It seems like the real fix here is to use set -e so that any error in the generated launch_container.sh causes the script to exit and return a bad status code rather than trying to predict what may or may not be valid env var definitions.

> When an export var command fails in launch_container.sh, the full container launch should fail
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-5219
>                 URL: https://issues.apache.org/jira/browse/YARN-5219
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Sunil G
>         Attachments: YARN-5219-branch-2.001.patch, YARN-5219.001.patch, YARN-5219.003.patch
>
>
> Today, a container fails if certain files fail to localize. However, if certain env vars fail to get setup properly either due to bugs in the yarn application or misconfiguration, the actual process launch still gets triggered. This results in either confusing error messages if the process fails to launch or worse yet the process launches but then starts behaving wrongly if the env var is used to control some behavioral aspects. 
> In this scenario, the issue was reproduced by trying to do export abc="$\{foo.bar}" which is invalid as var names cannot contain "." in bash. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org