You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2021/02/18 19:52:00 UTC
[GitHub] [incubator-heron] nicknezis opened a new pull request #3675: Specifying explicit transitive dependency for `uvloop`
nicknezis opened a new pull request #3675:
URL: https://github.com/apache/incubator-heron/pull/3675
Adding a temporary fix until uvicorn fix is released. Resolves #3674
This will eventually be fixed by bumping the version of `uvicorn`, but the fix found [here](https://github.com/encode/uvicorn/pull/952) is not yet released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on a change in pull request #3675: Specifying explicit transitive dependency for `uvloop`
Posted by GitBox <gi...@apache.org>.
nicknezis commented on a change in pull request #3675:
URL: https://github.com/apache/incubator-heron/pull/3675#discussion_r578726458
##########
File path: heron/tools/ui/src/python/BUILD
##########
@@ -13,6 +13,7 @@ pex_library(
"jinja2==2.11.2",
"aiofiles==0.5.0",
"uvicorn==0.11.7",
+ "uvloop==0.14.0",
Review comment:
Yup. Looks like only in Heron UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] Code0x58 commented on a change in pull request #3675: Specifying explicit transitive dependency for `uvloop`
Posted by GitBox <gi...@apache.org>.
Code0x58 commented on a change in pull request #3675:
URL: https://github.com/apache/incubator-heron/pull/3675#discussion_r578711023
##########
File path: heron/tools/ui/src/python/BUILD
##########
@@ -13,6 +13,7 @@ pex_library(
"jinja2==2.11.2",
"aiofiles==0.5.0",
"uvicorn==0.11.7",
+ "uvloop==0.14.0",
Review comment:
is this the only BUILD file with uvicorn in it? If so, 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis merged pull request #3675: Specifying explicit transitive dependency for `uvloop`
Posted by GitBox <gi...@apache.org>.
nicknezis merged pull request #3675:
URL: https://github.com/apache/incubator-heron/pull/3675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org