You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/12 06:23:24 UTC
[GitHub] [openwhisk-client-go] ningyougang opened a new pull request #137: Add DelAnnotations field to support del annotation
ningyougang opened a new pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137
Currently, if passing another annotations, original previous annotation
will be removed and the passed new annotations will be added.
It may give users some confused that why my previous annotation gone.
So it is better to not delete user's previous annotation when adding new
annotation, but at the same time, need to provide a feature that
support to delete annotation by user via ClI, e.g.
```shell
wsk action update hello --del-annotation key1 --del-annotation key2
```
another brother prs to support del annotation:
* https://github.com/apache/openwhisk-cli/pull/488
* https://github.com/apache/openwhisk/pull/4940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] ningyougang closed pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] ningyougang commented on pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
ningyougang commented on pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137#issuecomment-672759288
It seems build error
It seems have no relation with my codes, is it travis problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] ningyougang closed pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] ningyougang closed pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] ningyougang closed pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] ningyougang commented on a change in pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
ningyougang commented on a change in pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137#discussion_r469032396
##########
File path: whisk/action.go
##########
@@ -31,17 +31,18 @@ type ActionService struct {
}
type Action struct {
- Namespace string `json:"namespace,omitempty"`
- Name string `json:"name,omitempty"`
- Version string `json:"version,omitempty"`
- Exec *Exec `json:"exec,omitempty"`
- Annotations KeyValueArr `json:"annotations,omitempty"`
- Parameters KeyValueArr `json:"parameters,omitempty"`
- Limits *Limits `json:"limits,omitempty"`
- Error string `json:"error,omitempty"`
- Code int `json:"code,omitempty"`
- Publish *bool `json:"publish,omitempty"`
- Updated int64 `json:"updated,omitempty"`
+ Namespace string `json:"namespace,omitempty"`
+ Name string `json:"name,omitempty"`
+ Version string `json:"version,omitempty"`
+ Exec *Exec `json:"exec,omitempty"`
+ Annotations KeyValueArr `json:"annotations,omitempty"`
+ DelAnnotations []string `json:"delAnnotations,omitempty"`
Review comment:
Just added field `DelAnnotations []string `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] ningyougang edited a comment on pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
ningyougang edited a comment on pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137#issuecomment-672759288
It seems build error
It seems have no relation with my codes, is it travis problem?
this build error can be solved by this pr: https://github.com/apache/openwhisk-client-go/pull/138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] style95 merged pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
style95 merged pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] ningyougang closed pull request #137: Add DelAnnotations field to support del annotation
Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #137:
URL: https://github.com/apache/openwhisk-client-go/pull/137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org