You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/03/12 05:05:22 UTC
[GitHub] [flink] klion26 commented on a change in pull request #7958:
[FLINK-11881][table-planner-blink] Introduce code generated typed sort to
blink table
klion26 commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table
URL: https://github.com/apache/flink/pull/7958#discussion_r264520383
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/NestedRow.java
##########
@@ -256,6 +256,14 @@ public Decimal getDecimal(int pos, int precision, int scale) {
return BinaryGeneric.readBinaryGenericFieldFromSegments(segments, offset, getLong(pos));
}
+ @Override
+ public byte[] getBinary(int pos) {
+ assertIndexIsValid(pos);
+ int fieldOffset = getFieldOffset(pos);
+ final long offsetAndLen = segments[0].getLong(fieldOffset);
Review comment:
Do we need to check `segments` is empty or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services