You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2010/10/02 14:33:32 UTC
[jira] Created: (MSITE-508) attach-descriptor goals leaks file
handlers, causing sporadic build failures when gpg tries to sign descriptor
during release
attach-descriptor goals leaks file handlers, causing sporadic build failures when gpg tries to sign descriptor during release
-----------------------------------------------------------------------------------------------------------------------------
Key: MSITE-508
URL: http://jira.codehaus.org/browse/MSITE-508
Project: Maven 2.x Site Plugin
Issue Type: Bug
Components: site descriptor
Affects Versions: 3.0-beta-2, 2.1.1
Reporter: Benjamin Bentmann
An excerpt from a debug log:
{noformat}
[INFO] --- maven-site-plugin:3.0-beta-2:attach-descriptor (attach-descriptor) @ mojo-parent ---
[INFO] Parent project loaded from repository.
[DEBUG] Attaching the site descriptor 'D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml' with classifier 'site' to the project.
[INFO]
[INFO] --- maven-gpg-plugin:1.1:sign (sign-artifacts) @ mojo-parent ---
[DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT.pom
[DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-source-release.zip
[DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml
gpg: can't open `D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml': No error
gpg: signing failed: file open error
{noformat}
The cause for this is that {{site:attach-descriptor}} leaks at least two file handles, once in the call {{IOUtil.toString( ReaderFactory.newXmlReader( descriptorFile ) );}} and more importantly in {{Writer writer = WriterFactory.newXmlWriter( interpolatedDescriptorFile );}}. Those readers/writers get never closed, and can prevent other mojos from properly accessing those files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSITE-508) attach-descriptor goals leaks file
handlers, causing sporadic build failures when gpg tries to sign descriptor
during release
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSITE-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=237283#action_237283 ]
Olivier Lamy commented on MSITE-508:
------------------------------------
fixed in branch 3.x rev 1003823
> attach-descriptor goals leaks file handlers, causing sporadic build failures when gpg tries to sign descriptor during release
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: MSITE-508
> URL: http://jira.codehaus.org/browse/MSITE-508
> Project: Maven 2.x Site Plugin
> Issue Type: Bug
> Components: site descriptor
> Affects Versions: 2.1.1, 3.0-beta-2
> Reporter: Benjamin Bentmann
> Assignee: Olivier Lamy
> Fix For: 2.2, 3.0-beta-3
>
>
> An excerpt from a debug log:
> {noformat}
> [INFO] --- maven-site-plugin:3.0-beta-2:attach-descriptor (attach-descriptor) @ mojo-parent ---
> [INFO] Parent project loaded from repository.
> [DEBUG] Attaching the site descriptor 'D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml' with classifier 'site' to the project.
> [INFO]
> [INFO] --- maven-gpg-plugin:1.1:sign (sign-artifacts) @ mojo-parent ---
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT.pom
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-source-release.zip
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml
> gpg: can't open `D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml': No error
> gpg: signing failed: file open error
> {noformat}
> The cause for this is that {{site:attach-descriptor}} leaks at least two file handles, once in the call {{IOUtil.toString( ReaderFactory.newXmlReader( descriptorFile ) );}} and more importantly in {{Writer writer = WriterFactory.newXmlWriter( interpolatedDescriptorFile );}}. Those readers/writers get never closed, and can prevent other mojos from properly accessing those files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSITE-508) attach-descriptor goals leaks file
handlers, causing sporadic build failures when gpg tries to sign descriptor
during release
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSITE-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MSITE-508.
------------------------------
Resolution: Fixed
merged in 2.x branch rev 1003826
> attach-descriptor goals leaks file handlers, causing sporadic build failures when gpg tries to sign descriptor during release
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: MSITE-508
> URL: http://jira.codehaus.org/browse/MSITE-508
> Project: Maven 2.x Site Plugin
> Issue Type: Bug
> Components: site descriptor
> Affects Versions: 2.1.1, 3.0-beta-2
> Reporter: Benjamin Bentmann
> Assignee: Olivier Lamy
> Fix For: 2.2, 3.0-beta-3
>
>
> An excerpt from a debug log:
> {noformat}
> [INFO] --- maven-site-plugin:3.0-beta-2:attach-descriptor (attach-descriptor) @ mojo-parent ---
> [INFO] Parent project loaded from repository.
> [DEBUG] Attaching the site descriptor 'D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml' with classifier 'site' to the project.
> [INFO]
> [INFO] --- maven-gpg-plugin:1.1:sign (sign-artifacts) @ mojo-parent ---
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT.pom
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-source-release.zip
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml
> gpg: can't open `D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml': No error
> gpg: signing failed: file open error
> {noformat}
> The cause for this is that {{site:attach-descriptor}} leaks at least two file handles, once in the call {{IOUtil.toString( ReaderFactory.newXmlReader( descriptorFile ) );}} and more importantly in {{Writer writer = WriterFactory.newXmlWriter( interpolatedDescriptorFile );}}. Those readers/writers get never closed, and can prevent other mojos from properly accessing those files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSITE-508) attach-descriptor goals leaks file
handlers, causing sporadic build failures when gpg tries to sign descriptor
during release
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSITE-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MSITE-508:
-------------------------------
Fix Version/s: 3.0-beta-3
2.2
Assignee: Olivier Lamy
> attach-descriptor goals leaks file handlers, causing sporadic build failures when gpg tries to sign descriptor during release
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: MSITE-508
> URL: http://jira.codehaus.org/browse/MSITE-508
> Project: Maven 2.x Site Plugin
> Issue Type: Bug
> Components: site descriptor
> Affects Versions: 2.1.1, 3.0-beta-2
> Reporter: Benjamin Bentmann
> Assignee: Olivier Lamy
> Fix For: 2.2, 3.0-beta-3
>
>
> An excerpt from a debug log:
> {noformat}
> [INFO] --- maven-site-plugin:3.0-beta-2:attach-descriptor (attach-descriptor) @ mojo-parent ---
> [INFO] Parent project loaded from repository.
> [DEBUG] Attaching the site descriptor 'D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml' with classifier 'site' to the project.
> [INFO]
> [INFO] --- maven-gpg-plugin:1.1:sign (sign-artifacts) @ mojo-parent ---
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT.pom
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-source-release.zip
> [DEBUG] Generating signature for D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml
> gpg: can't open `D:\codehaus\mojo\mojo\mojo-parent\target\mojo-parent-27-SNAPSHOT-site.xml': No error
> gpg: signing failed: file open error
> {noformat}
> The cause for this is that {{site:attach-descriptor}} leaks at least two file handles, once in the call {{IOUtil.toString( ReaderFactory.newXmlReader( descriptorFile ) );}} and more importantly in {{Writer writer = WriterFactory.newXmlWriter( interpolatedDescriptorFile );}}. Those readers/writers get never closed, and can prevent other mojos from properly accessing those files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira