You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/11 08:02:41 UTC

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8078: sim/posix/sim_linuxspi.c: fix select not work and incorrect behaviour

pkarashchenko commented on code in PR #8078:
URL: https://github.com/apache/nuttx/pull/8078#discussion_r1066677756


##########
arch/sim/src/sim/posix/sim_linuxspi.c:
##########
@@ -191,6 +191,26 @@ static int linux_spi_lock(struct spi_dev_s *dev, bool lock)
 static void linux_spi_select(struct spi_dev_s *dev, uint32_t devid,
                              bool selected)
 {
+  if (selected == false)

Review Comment:
   ```suggestion
     if (!selected)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org