[incubator-iceberg] branch master updated: Make original ManifestReader factory method public. (#385)

[bl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new ead1a5c  Make original ManifestReader factory method public. (#385)
ead1a5c is described below

commit ead1a5c56619e01b671f00c93341fccdd5ff988b
Author: Ryan Blue <rd...@users.noreply.github.com>
AuthorDate: Thu Aug 15 09:17:35 2019 -0700

    Make original ManifestReader factory method public. (#385)
    
    This is easier to use when reading a manifest directly, even though the
    partition spec will use the schema from when the manifest was written,
    not the current table schema.
---
 core/src/main/java/org/apache/iceberg/ManifestReader.java | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/org/apache/iceberg/ManifestReader.java b/core/src/main/java/org/apache/iceberg/ManifestReader.java
index f960ce6..da1759b 100644
--- a/core/src/main/java/org/apache/iceberg/ManifestReader.java
+++ b/core/src/main/java/org/apache/iceberg/ManifestReader.java
@@ -58,8 +58,17 @@ public class ManifestReader extends CloseableGroup implements Filterable<Filtere
       .add("value_counts", "null_value_counts", "lower_bounds", "upper_bounds")
       .build();
 
-  // Visible for testing
-  static ManifestReader read(InputFile file) {
+  /**
+   * Returns a new {@link ManifestReader} for an {@link InputFile}.
+   * <p>
+   * <em>Note:</em> Most callers should use {@link #read(InputFile, Function)} to ensure that the
+   * schema used by filters is the latest table schema. This should be used only when reading a
+   * manifest without filters.
+   *
+   * @param file an InputFile
+   * @return a manifest reader
+   */
+  public static ManifestReader read(InputFile file) {
     return new ManifestReader(file, null);
   }