You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/23 22:50:38 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #1400: add get resource customized view in Helix admin
zhangmeng916 opened a new pull request #1400:
URL: https://github.com/apache/helix/pull/1400
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
fix #1399
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
As we provide customized view to our users, there is a request for retrieving customized view for a resource in Helix admin. It's similar as the current getResourceExternalView. This PR adds a new API for this function.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [X] The following is the result of the "mvn test" command on the appropriate module:
(Before CI test pass, please copy & paste the result of "mvn test")
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1400: add get resource customized view in Helix admin
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1400:
URL: https://github.com/apache/helix/pull/1400#issuecomment-698114902
Shall we add a unit test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1400: add get resource customized view in Helix admin
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1400:
URL: https://github.com/apache/helix/pull/1400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1400: add get resource customized view in Helix admin
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1400:
URL: https://github.com/apache/helix/pull/1400#issuecomment-698114902
Shall we add a unit test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #1400: add get resource customized view in Helix admin
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1400:
URL: https://github.com/apache/helix/pull/1400#issuecomment-698095161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #1400: add get resource customized view in Helix admin
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1400:
URL: https://github.com/apache/helix/pull/1400#issuecomment-698095161
This PR is ready to merge. Approved by @alirezazamani
Final commit message:
Add get resource customized view in Helix admin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #1400: add get resource customized view in Helix admin
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1400:
URL: https://github.com/apache/helix/pull/1400#issuecomment-698435172
> Shall we add a unit test?
Added one check similar to external view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1400: add get resource customized view in Helix admin
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1400:
URL: https://github.com/apache/helix/pull/1400
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org