You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/08/26 13:30:50 UTC
[GitHub] [knox] arvaiadam opened a new pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
arvaiadam opened a new pull request #369:
URL: https://github.com/apache/knox/pull/369
## What changes were proposed in this pull request?
In Oozie 5.x there is a new parameter called resourceManager. This is used instead of jobTracker. However, Oozie can fall back to jobTracker value if no resourceManager is defined. resourceManager shall have the same value as jobTracker has now.
This ticket is intend to track the work on adding a new rewrite rule and a new service returning the resource-manager's address.
Currently the JobTrackerServiceModelGenerator despite its name is actually returning the resource-manager's address. This is not enabled by default because its misleading name since we no longer have job-trackers but resource-managers.
By having a new service which does exactly the same thing as JobTrackerServiceModelGenerator but is enabled by default we could have Oozie work with Knox out of the box.
We should be careful as the resource manager service name is already taken by ResourceManagerUIServiceModelGenerator.
## How was this patch tested?
Updated/ran unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681743389
@arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within `gateway-service-definitions` (e.g. `5.0.0`) and leave the previous version as-is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681835861
@moresandeep, please review this PR when you have time. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-682435824
There is an ongoing issue with Github Actions for a while (for some PRs it's intermittent, for some it's more severe). Luckily, we have Travis in place which proves this PR is OK to merge so I'm going to do it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] arvaiadam commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
Posted by GitBox <gi...@apache.org>.
arvaiadam commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681841227
> @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is?
Thanks for your feedback, i changed accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 removed a comment on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
Posted by GitBox <gi...@apache.org>.
smolnar82 removed a comment on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681743389
@arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within `gateway-service-definitions` (e.g. `5.0.0`) and leave the previous version as-is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681841673
> > @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is?
>
> Thanks for your feedback, i changed accordingly.
Thanks, @arvaiadam! I really appreciate your fast feedback and action you've taken here!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #369:
URL: https://github.com/apache/knox/pull/369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] moresandeep commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
Posted by GitBox <gi...@apache.org>.
moresandeep commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681980575
Java8 job failed, re-triggered it. Once it passes we should be good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org