You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/11/12 06:01:54 UTC

[GitHub] spark pull request #15049: [SPARK-17310][SQL] Add an option to disable recor...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15049#discussion_r150401147
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala ---
    @@ -370,13 +372,11 @@ class ParquetFileFormat
           } else {
             logDebug(s"Falling back to parquet-mr")
             // ParquetRecordReader returns UnsafeRow
    -        val reader = pushed match {
    -          case Some(filter) =>
    -            new ParquetRecordReader[UnsafeRow](
    -              new ParquetReadSupport,
    -              FilterCompat.get(filter, null))
    -          case _ =>
    -            new ParquetRecordReader[UnsafeRow](new ParquetReadSupport)
    +        val reader = if (pushed.isDefined && enableRecordFilter) {
    --- End diff --
    
    @jiangxb1987 If you do not like the solution here, could you submit the one you propose?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org