You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/10/28 19:57:56 UTC

[kudu-CR] WIP: Fix SASL mechanism negotiation on the server side

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4875

to look at the new patch set (#2).

Change subject: WIP: Fix SASL mechanism negotiation on the server side
......................................................................

WIP: Fix SASL mechanism negotiation on the server side

This fixes the order in which the SASL server is initialized such that
the mechanism list is set up before the sasl_server_init function is
called. This is equivalent to the change made in Change ID
I3c1b93045acd428ef3437597059c5106b03e25d0 on the client side.

Without this change, the server would use a null mechanism list, which
was being treated as a wildcard.

The new test case configures a server to only accept GSSAPI, and then
has a client configured to accept GSSAPI or PLAIN. Before the fix, it
would negotiate PLAIN despite the attempt to require GSSAPI on the
server side. Now, it properly negotiates.

WIP because I need to add another test Alexey suggested

Change-Id: I4741ce618525311258d5ba61dd85f6f4721caf66
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/sasl_helper.cc
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/rpc/sasl_server.cc
4 files changed, 54 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/4875/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4741ce618525311258d5ba61dd85f6f4721caf66
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>