[jira] Assigned: (WICKET-2816) Refactor / rework pageability

["Igor Vaynberg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-2816:
-------------------------------------

    Assignee: Peter Ertl

looks good. +1 to apply.

> Refactor / rework pageability
> -----------------------------
>
>                 Key: WICKET-2816
>                 URL: https://issues.apache.org/jira/browse/WICKET-2816
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket, wicket-extensions
>    Affects Versions: 1.4.7, 1.5-M1
>         Environment: All
>            Reporter: Daniel Toffetti
>            Assignee: Peter Ertl
>         Attachments: pageable_v2.patch
>
>
> I need to add a NavigatorLabel to a GridView, now NavigatorLabel has constructors accepting DataTable, DataView and PageableListView but not a GridView.
> Instead of creating a new constructor accepting a GridView, I think it would be far better to merge IPageable and the private NavigatorLabel.PageableComponent into a single public interface and making all pageable components implement this interface.
> I understand this approach breaks APIs and will need one major version, maybe two allowing for deprecations in between.
> A less breaking alternative (but not as good in my opinion) is to change the constructor accepting a DataView to make it accept an AbstractPageableView, which is a common ancestor of both DataView and GridView and defines the methods needed to satisfy NavigatorLabel.PageableComponent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.