You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li via Review Board <no...@reviews.apache.org> on 2017/11/02 00:21:26 UTC
Review Request 63488: SENTRY-2029: Unit test fails consistently for
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63488/
-----------------------------------------------------------
Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
Repository: sentry
Description
-------
code change in "SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog."causes HMSFollower cannot connect to HMS in e2e tests. Revert "SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog."
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 630bc68
Diff: https://reviews.apache.org/r/63488/diff/1/
Testing
-------
unit tests show after reverting SENTRY-2017, TestDbPrivilegeCleanupOnDrop passes
Thanks,
Na Li
Re: Review Request 63488: SENTRY-2029: Unit test fails consistently
for
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63488/#review190027
-----------------------------------------------------------
Ship it!
Look's like adeeper issue. please proceed with the revert. I'm looking into the root. I have some findings.
- kalyan kumar kalvagadda
On Nov. 2, 2017, 12:21 a.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63488/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 12:21 a.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> code change in "SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog."causes HMSFollower cannot connect to HMS in e2e tests. Revert "SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog."
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 630bc68
>
>
> Diff: https://reviews.apache.org/r/63488/diff/1/
>
>
> Testing
> -------
>
> unit tests show after reverting SENTRY-2017, TestDbPrivilegeCleanupOnDrop passes
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 63488: SENTRY-2029: Unit test fails consistently
for
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegeCleanupOnDrop
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63488/#review189956
-----------------------------------------------------------
Let's not revert it the change. let's try to figure the root cause of the failure. If we can not fix it today then we can revert the change.
- kalyan kumar kalvagadda
On Nov. 2, 2017, 12:21 a.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63488/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 12:21 a.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> code change in "SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog."causes HMSFollower cannot connect to HMS in e2e tests. Revert "SENTRY-2017: Fix Sentry e2e tests to use SentryMetastorePostEventListenerNotificationLog."
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 630bc68
>
>
> Diff: https://reviews.apache.org/r/63488/diff/1/
>
>
> Testing
> -------
>
> unit tests show after reverting SENTRY-2017, TestDbPrivilegeCleanupOnDrop passes
>
>
> Thanks,
>
> Na Li
>
>