[jira] [Commented] (PIG-2125) Make Pig work with hadoop .NEXT

["Alan Gates (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064053#comment-13064053 ] 

Alan Gates commented on PIG-2125:
---------------------------------

In general the patch looks good.  I have a few questions/comments.

# How does one build a 0.23 compatible version of Pig?  Do you have to download the 0.23 jar yourself?  It looked like if you did this, build.xml would manage the rest properly.  The answer to this question will need to be added to the release notes field of this JIRA.
# Javadocs explaining what the classes do would be very helpful.  PigMapReduce, PigMapBase, HadoopShims all could use class level comments.  HadoopShims in particular should have extensive comments on how the shims layer works and what needs to be shimmed.
# I wonder if HadoopShims should go in a separate package.  I know it's just one class, but it performs a unique function.  This would also allow many of the design and build comments I referenced in the last point to be covered in a package level doc.  I don't feel strongly about this, so feel free to keep it where it is if you think that's better.

> Make Pig work with hadoop .NEXT
> -------------------------------
>
>                 Key: PIG-2125
>                 URL: https://issues.apache.org/jira/browse/PIG-2125
>             Project: Pig
>          Issue Type: New Feature
>          Components: impl
>    Affects Versions: 0.10
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.10
>
>         Attachments: PIG-2125-1.patch, PIG-2125-2.patch, PIG-2125-3.patch
>
>
> We need to make Pig work with hadoop .NEXT, the svn branch currently is: https://svn.apache.org/repos/asf/hadoop/common/branches/MR-279

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira