You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kakoni (via GitHub)" <gi...@apache.org> on 2023/06/05 11:56:48 UTC
[GitHub] [superset] kakoni opened a new issue, #24290: supersetCanCSV property naming could be better
kakoni opened a new issue, #24290:
URL: https://github.com/apache/superset/issues/24290
## Description
Javascript code uses `supersetCanCSV` property to check wether user is allowed to download chart as csv, excel or image.
This is bit outdated, `supersetCanDownload` would be more informative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] supersetCanCSV property naming could be better [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #24290:
URL: https://github.com/apache/superset/issues/24290#issuecomment-1977349359
Yes let's put it on the possibilities list for 5.0. This would be a meaningful improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on issue #24290: supersetCanCSV property naming could be better
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #24290:
URL: https://github.com/apache/superset/issues/24290#issuecomment-1601081036
Maybe tag as a candidate for 4.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #24290: supersetCanCSV property naming could be better
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #24290:
URL: https://github.com/apache/superset/issues/24290#issuecomment-1626157366
We're going to be looking at permissions in the next few months and have been having the same general feeling about a lot of them, that a new naming would help. Definitely sounds like something we can consider for 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #24290: supersetCanCSV property naming could be better
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24290:
URL: https://github.com/apache/superset/issues/24290#issuecomment-1583051159
It's really that `can_csv` permission I'm nervous about renaming. People might have automation build around it, thus the breaking change risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #24290: supersetCanCSV property naming could be better
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24290:
URL: https://github.com/apache/superset/issues/24290#issuecomment-1581434528
I think the main wrinkle here is that it could be considered a breaking change to rename this sort of thing.
@eschutho @villebro @john-bodley have any feelings on the naming or the process around this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] supersetCanCSV property naming could be better [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24290:
URL: https://github.com/apache/superset/issues/24290#issuecomment-1977380379
Done :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kakoni commented on issue #24290: supersetCanCSV property naming could be better
Posted by "kakoni (via GitHub)" <gi...@apache.org>.
kakoni commented on issue #24290:
URL: https://github.com/apache/superset/issues/24290#issuecomment-1581941023
For reference see
https://github.com/apache/superset/blob/e13b80aff1821d6875b74045780e13b5c3913e6a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx#L481
(Used to control if download menu is visible. Has csv,xlsx and image options)
In python code this is in someplace already called download permission
https://github.com/apache/superset/blob/e13b80aff1821d6875b74045780e13b5c3913e6a/superset/views/core.py#L926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] supersetCanCSV property naming could be better [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24290:
URL: https://github.com/apache/superset/issues/24290#issuecomment-1977342138
The 4.0 ship has sailed... is anyone looking to get this on the docket for 5.0, or shall we close this as a stale issue / feature request? It's not really a bug, so I'd be tempted to close it anyway, but people seem to care :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org