You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2017/11/06 21:30:57 UTC

[Impala-ASF-CR] IMPALA-5473: [DOCS] Document TLS min version & cipher options

Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8401 )

Change subject: IMPALA-5473: [DOCS] Document TLS min version & cipher options
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Sorry dropped this earlier.

This LGTM after these minor changes.

http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml
File docs/topics/impala_ssl.xml:

http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml@177
PS2, Line 177: TLSv1.2 may not work
> Good question for Sailesh!
The daemon doesn't start. Specifically, we get an error like this:

SSL socket creation failed: TLS (8) version not supported (linked OpenSSL version is 268435459)
    @           0x8eeaba  impala::Status::Status()
    @           0xa82107  impala::ThriftServer::CreateSocket()
    @           0xa8502c  impala::ThriftServer::Start()
    @           0xbe3dc0  impala::StatestoreSubscriber::Start()
    @           0x8c7164  impala::CatalogServer::Start()
    @           0x8becd4  CatalogdMain()
    @           0x879ea6  main
    @     0x7f4b30f63d1d  __libc_start_main
    @           0x8be0b1  (unknown)


So we can add the detail that Impala will refuse to start.


http://gerrit.cloudera.org:8080/#/c/8401/2/docs/topics/impala_ssl.xml@188
PS2, Line 188:  
nit: whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/8401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1705262f8c01e38c616541d1c48f5d0cad5498e
Gerrit-Change-Number: 8401
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Nov 2017 21:30:57 +0000
Gerrit-HasComments: Yes