[GitHub] incubator-hivemall issue #79: [HIVEMALL-101] Separate optimizer implementati...

[takuti <gi...@git.apache.org>]

Github user takuti commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/79
  
    @myui Almost done basically. Could you review when you get a chance?
    
    One thing I like to discuss here is that `GeneralClassifierUDTF` and `GeneralRegressionUDTF` currently has a lot of duplicated code. Thus, current class structure
    
    - Learner Base 
      - Binary Online Classifier 
        - General Classifier
      - Regression Base
        - General Regression
    
    can be modified to
    
    - Learner Base
      - General Predictor Base
        - General Classifier
        - General Regression
    
    for example. 
    
    If it sounds good for @myui, I will do so. Of course it's not mandatory, so keeping the current duplicated code is no problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---