You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/20 02:40:16 UTC

[GitHub] [iceberg] hililiwei commented on pull request #3893: Flink: Port TestProjectMetaColumn to Flink 1.14 to check whether should remove meta columns in source reader

hililiwei commented on pull request #3893:
URL: https://github.com/apache/iceberg/pull/3893#issuecomment-1017063411


   > One minor thing, when we port the patch, we usually log the message as:
   > 
   > ```
   > <Engine> <Version>: <Message>
   > ```
   > 
   > So in theory, in this PR. we recommend to title it as :
   > 
   > ```
   > Flink 1.14: Add tests to check whether should remove meta columns in source reader
   > ```
   Got it. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org