[GitHub] [fineract] galovics commented on a diff in pull request #2689: FINERACT-1758: Improve custom module example (fix)

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2689:
URL: https://github.com/apache/fineract/pull/2689#discussion_r1001569136


##########
fineract-doc/src/docs/en/chapters/architecture/modules.adoc:
##########
@@ -63,6 +63,15 @@ If database migrations are needed as part of your customizations then you can ad
 include::{diagramsdir}/custom-db-migration-folder-structure.puml[]
 ----
 
+And here an example migration script:
+
+[source,xml]
+----
+include::{rootdir}/custom/acme/note/starter/src/main/resources/db/custom-changelog/0001_acme_note_initial.xml[lines=22..]
+----
+
+IMPORTANT: Please make sure your `changeSet` tag has the attribute `context` set to `tenant_db`. That makes sure your changes will be applied to the tenant database (read: main database and not the tenant store database). In theory you could also target the tenant configuration database, but it's not recommended to do that.

Review Comment:
   What if we just disallow touching the tenant configuration DB? I think the tenant config should be tied to the shipped Fineract implementation. No custom module should touch it.
   
   Having said that, the context=tenant_db could go one level upper to only include changeSets when its the tenant_db
   
   Thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org