You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/15 14:49:19 UTC

[GitHub] [incubator-shardingsphere] zjcnb opened a new pull request #4768: add sql state and vendor code for this

zjcnb opened a new pull request #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768
 
 
   Fixes #4654
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#discussion_r393056084
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/EncryptResultSetMetaData.java
 ##########
 @@ -89,8 +90,7 @@ public String getColumnName(final int column) throws SQLException {
         if (sqlStatementContext instanceof SelectStatementContext) {
             List<Projection> actualProjections = ((SelectStatementContext) sqlStatementContext).getProjectionsContext().getExpandProjections();
             if (column > actualProjections.size()) {
-                // TODO fill correct SQL state
-                throw new SQLException(String.format("Out of index of projection %s", column));
+                throw new SQLException(String.format("Out of index of projection %s", column), SQLExceptionConstant.OUT_OF_INDEX_SQL_STAT, 0);
 
 Review comment:
   Maybe we need to check string information "Out of index of projection %s" too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#issuecomment-599433764
 
 
   ## Pull Request Test Coverage Report for [Build 10279](https://coveralls.io/builds/29378803)
   
   * **0** of **2**   **(0.0%)**  changed or added relevant lines in **2** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.005%**) to **59.647%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/EncryptResultSetMetaData.java](https://coveralls.io/builds/29378803/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fresultset%2FEncryptResultSetMetaData.java#L93) | 0 | 1 | 0.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/ShardingResultSetMetaData.java](https://coveralls.io/builds/29378803/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fresultset%2FShardingResultSetMetaData.java#L96) | 0 | 1 | 0.0%
   <!-- | **Total:** | **0** | **2** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29378803/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29378803/badge)](https://coveralls.io/builds/29378803) |
   | :-- | --: |
   | Change from base [Build 1084](https://coveralls.io/builds/29376659): |  -0.005% |
   | Covered Lines: | 12453 |
   | Relevant Lines: | 20878 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#issuecomment-599430849
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=h1) Report
   > Merging [#4768](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/93ecfd255952a5cdc63587e5bb3e3ecafc39fb43?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4768   +/-   ##
   =========================================
     Coverage     56.09%   56.09%           
     Complexity      441      441           
   =========================================
     Files          1157     1157           
     Lines         20878    20878           
     Branches       3863     3863           
   =========================================
     Hits          11711    11711           
     Misses         8437     8437           
     Partials        730      730
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../jdbc/core/resultset/EncryptResultSetMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L0VuY3J5cHRSZXN1bHRTZXRNZXRhRGF0YS5qYXZh) | `3.57% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...jdbc/core/resultset/ShardingResultSetMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L1NoYXJkaW5nUmVzdWx0U2V0TWV0YURhdGEuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=footer). Last update [93ecfd2...71a1329](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#discussion_r393055349
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/constant/SQLExceptionConstant.java
 ##########
 @@ -27,4 +27,6 @@
 public final class SQLExceptionConstant {
     
     public static final String SQL_STRING_NULL_OR_EMPTY = "SQL String can not be NULL or empty.";
+    
+    public static final String OUT_OF_INDEX_SQL_STAT = "S1002";
 
 Review comment:
   Please do not use abbreviation as variable name
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#issuecomment-599433764
 
 
   ## Pull Request Test Coverage Report for [Build 10290](https://coveralls.io/builds/29397651)
   
   * **0** of **2**   **(0.0%)**  changed or added relevant lines in **2** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.005%**) to **59.742%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/EncryptResultSetMetaData.java](https://coveralls.io/builds/29397651/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fresultset%2FEncryptResultSetMetaData.java#L93) | 0 | 1 | 0.0%
   | [sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/resultset/ShardingResultSetMetaData.java](https://coveralls.io/builds/29397651/source?filename=sharding-jdbc%2Fsharding-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fjdbc%2Fcore%2Fresultset%2FShardingResultSetMetaData.java#L96) | 0 | 1 | 0.0%
   <!-- | **Total:** | **0** | **2** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29397651/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29397651/badge)](https://coveralls.io/builds/29397651) |
   | :-- | --: |
   | Change from base [Build 1087](https://coveralls.io/builds/29394371): |  -0.005% |
   | Covered Lines: | 12483 |
   | Relevant Lines: | 20895 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#discussion_r392689346
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/constant/SQLExceptionConstant.java
 ##########
 @@ -27,4 +27,8 @@
 public final class SQLExceptionConstant {
     
     public static final String SQL_STRING_NULL_OR_EMPTY = "SQL String can not be NULL or empty.";
+    
+    public static final String SQL_STATE = "S1002";
 
 Review comment:
   `SQL_STATE` is a common name, but the value is `S1002`, it is not a good variable name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#issuecomment-599430849
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=h1) Report
   > Merging [#4768](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/784fde4a785a5936838b49c894850b3ecb424baf&el=desc) will **increase** coverage by `0.10%`.
   > The diff coverage is `67.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4768      +/-   ##
   ============================================
   + Coverage     56.09%   56.19%   +0.10%     
   - Complexity      442      448       +6     
   ============================================
     Files          1157     1163       +6     
     Lines         20877    20895      +18     
     Branches       3863     3880      +17     
   ============================================
   + Hits          11710    11742      +32     
   + Misses         8438     8424      -14     
     Partials        729      729              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ngsphere/core/metadata/ShardingMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../core/metadata/ShardingTableMetaDataDecorator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ1RhYmxlTWV0YURhdGFEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...c/jdbc/core/context/MasterSlaveRuntimeContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9NYXN0ZXJTbGF2ZVJ1bnRpbWVDb250ZXh0LmphdmE=) | `85.71% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/jdbc/core/context/ShardingRuntimeContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvY29udGV4dC9TaGFyZGluZ1J1bnRpbWVDb250ZXh0LmphdmE=) | `83.33% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../jdbc/core/resultset/EncryptResultSetMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L0VuY3J5cHRSZXN1bHRTZXRNZXRhRGF0YS5qYXZh) | `3.57% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/core/resultset/ShardingResultSetMetaData.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvcmVzdWx0c2V0L1NoYXJkaW5nUmVzdWx0U2V0TWV0YURhdGEuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy93cmFwcGVyL1ByZXBhcmVkU3RhdGVtZW50RXhlY3V0b3JXcmFwcGVyLmphdmE=) | `1.53% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ication/jdbc/wrapper/StatementExecutorWrapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy93cmFwcGVyL1N0YXRlbWVudEV4ZWN1dG9yV3JhcHBlci5qYXZh) | `1.61% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...value/decimal/MySQLDecimalBinlogProtocolValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9kZWNpbWFsL015U1FMRGVjaW1hbEJpbmxvZ1Byb3RvY29sVmFsdWUuamF2YQ==) | `90.90% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../value/decimal/MySQLDoubleBinlogProtocolValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9kZWNpbWFsL015U1FMRG91YmxlQmlubG9nUHJvdG9jb2xWYWx1ZS5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | ... and [40 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=footer). Last update [3df3a21...cc7e569](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4768?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] zjcnb commented on a change in pull request #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
zjcnb commented on a change in pull request #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#discussion_r392818989
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/constant/SQLExceptionConstant.java
 ##########
 @@ -27,4 +27,8 @@
 public final class SQLExceptionConstant {
     
     public static final String SQL_STRING_NULL_OR_EMPTY = "SQL String can not be NULL or empty.";
+    
+    public static final String SQL_STATE = "S1002";
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4768: add sql state and vendor code for this

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4768: add sql state and vendor code for this
URL: https://github.com/apache/incubator-shardingsphere/pull/4768#discussion_r392689370
 
 

 ##########
 File path: sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/constant/SQLExceptionConstant.java
 ##########
 @@ -27,4 +27,8 @@
 public final class SQLExceptionConstant {
     
     public static final String SQL_STRING_NULL_OR_EMPTY = "SQL String can not be NULL or empty.";
+    
+    public static final String SQL_STATE = "S1002";
+    
+    public static final int SQL_VENDOR_CODE = 0;
 
 Review comment:
   Same with `SQL_STATE`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services