You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/22 03:26:32 UTC
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1909: chore: sync JSON Schema from APISIX 2.6
liuxiran commented on a change in pull request #1909:
URL: https://github.com/apache/apisix-dashboard/pull/1909#discussion_r637346814
##########
File path: api/conf/schema.json
##########
@@ -2664,7 +2745,7 @@
"type": "integer"
},
"vars": {
- "items": {
+ "item": {
Review comment:
Ditto
##########
File path: api/conf/schema.json
##########
@@ -2642,7 +2723,7 @@
"type": "integer"
},
"vars": {
- "items": {
+ "item": {
Review comment:
I tried edit `fault-injection` plugin in FE, an error occured:
refer to
* https://json-schema.org/understanding-json-schema/reference/array.html
the reason is that in JSON Schema, it should use `items` to define the array item type
and after I changed `item` to `items`, Fe passed.
So It should rollback this change IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org