You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2025/08/05 17:29:57 UTC
[PR] i18n(tw): Add human in the loop translations [airflow]
guan404ming opened a new pull request, #54147:
URL: https://github.com/apache/airflow/pull/54147
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Why
Update zh-TW translation for new HITL UI.
<img width="759" height="404" alt="image" src="https://github.com/user-attachments/assets/5a622759-eb74-48a2-bc4f-6782765db22f" />
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(tw): Add translations for human in the loop [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #54147:
URL: https://github.com/apache/airflow/pull/54147#discussion_r2255687221
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -15,6 +15,7 @@
"backfill_other": "回填",
"browse": {
"auditLog": "審計日誌",
+ "requiredActions": "必要動作",
Review Comment:
Feel more like pending action/response ("待回應")?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(tw): Add translations for human in the loop [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54147:
URL: https://github.com/apache/airflow/pull/54147#discussion_r2255697482
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -15,6 +15,7 @@
"backfill_other": "回填",
"browse": {
"auditLog": "審計日誌",
+ "requiredActions": "必要動作",
Review Comment:
How about "待回應的任務實例" or "待回應的人類參與流程任務實例"? I think this should be a noun since we also need to sync translation of `requiredActionState`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(tw): Add translations for human in the loop [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54147:
URL: https://github.com/apache/airflow/pull/54147#discussion_r2255793962
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -15,6 +15,7 @@
"backfill_other": "回填",
"browse": {
"auditLog": "審計日誌",
+ "requiredActions": "必要動作",
Review Comment:
> 待回應的人類參與流程任務實例 is way too long...
Make sense haha~
> 待回應的任務實例 is great! It's accurate enough (HITL task instances are the only ones waiting)
Sure, let's use this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(tw): Add translations for human in the loop [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #54147:
URL: https://github.com/apache/airflow/pull/54147#discussion_r2255700357
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -15,6 +15,7 @@
"backfill_other": "回填",
"browse": {
"auditLog": "審計日誌",
+ "requiredActions": "必要動作",
Review Comment:
`待回應的人類參與流程任務實例` is way too long...
`待回應的任務實例` is great! It's accurate enough (HITL task instances are the only ones waiting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(tw): Add translations for human in the loop [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54147:
URL: https://github.com/apache/airflow/pull/54147#discussion_r2255793962
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -15,6 +15,7 @@
"backfill_other": "回填",
"browse": {
"auditLog": "審計日誌",
+ "requiredActions": "必要動作",
Review Comment:
> 待回應的人類參與流程任務實例 is way too long...
Make sense, it would mess up all tabs.
> 待回應的任務實例 is great! It's accurate enough (HITL task instances are the only ones waiting)
Sure, let's use this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(tw): Add translations for human in the loop [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #54147:
URL: https://github.com/apache/airflow/pull/54147#discussion_r2256220357
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -15,6 +15,7 @@
"backfill_other": "回填",
"browse": {
"auditLog": "審計日誌",
+ "requiredActions": "必要動作",
Review Comment:
If then, should we update semantic for English as well?
https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/ui/public/i18n/locales/en/common.json#L18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(tw): Add translations for human in the loop [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #54147:
URL: https://github.com/apache/airflow/pull/54147#discussion_r2256254957
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json:
##########
@@ -15,6 +15,7 @@
"backfill_other": "回填",
"browse": {
"auditLog": "審計日誌",
+ "requiredActions": "必要動作",
Review Comment:
Either way works for me. 👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(tw): Add translations for human in the loop [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #54147:
URL: https://github.com/apache/airflow/pull/54147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org