[jira] [Commented] (HIVE-18878) Lower MoveTask Lock Logging to Debug

["BELUGA BEHR (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425669#comment-16425669 ] 

BELUGA BEHR commented on HIVE-18878:
------------------------------------

[~stakiar]I Re-worked the patch to put a single log message in there at the top instead of for each individual lock.

 

I also added some other small goodies.

> Lower MoveTask Lock Logging to Debug
> ------------------------------------
>
>                 Key: HIVE-18878
>                 URL: https://issues.apache.org/jira/browse/HIVE-18878
>             Project: Hive
>          Issue Type: Improvement
>          Components: Locking
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: Igor Kryvenko
>            Priority: Minor
>              Labels: noob
>         Attachments: HIVE-18878.1.patch, HIVE-18878.2.patch, HIVE-18878.patch
>
>
> https://github.com/apache/hive/blob/cbb9233a3b39ab8489d777fc76f0758c49b69bef/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java#L233-L234
> {code}
>             LOG.info("about to release lock for output: {} lock: {}", output,
>               lock.getHiveLockObject().getName());
>             try {
>               lockMgr.unlock(lock);
>             } catch (LockException le) {
> {code}
> Change this to _debug_ level logging.  The lock manager's 'unlock' method should have additional logging available.  Knowing that the unlock is about to take place is only helpful for debugging, not for normal operation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)