You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/15 03:20:25 UTC

[GitHub] [spark] JoshRosen edited a comment on issue #24765: [SPARK-27915][SQL][WIP] Update logical Filter's output nullability based on IsNotNull conditions

JoshRosen edited a comment on issue #24765: [SPARK-27915][SQL][WIP] Update logical Filter's output nullability based on IsNotNull conditions
URL: https://github.com/apache/spark/pull/24765#issuecomment-511259953
 
 
   /cc @maropu, who submitted a very similar change ~1 year prior in #21148 (I was unaware of that PR when I created this one).
   
   Chasing down references from that PR, I discovered https://github.com/apache/spark/pull/23390 and https://github.com/apache/spark/pull/23508, both of which are concerned with fixing up nullability in attribute references; maybe one of those holds the blocker identified in my previous comment.
   
   **Update**: on closer reading, it sounds like I might actually need the code removed in #23508 in order for this to work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org