[GitHub] [trafficcontrol] Shihta commented on a change in pull request #3372: CIAB: remove tccache

[GitBox <gi...@apache.org>]

Shihta commented on a change in pull request #3372: CIAB: remove tccache
URL: https://github.com/apache/trafficcontrol/pull/3372#discussion_r263213119
 
 

 ##########
 File path: infrastructure/cdn-in-a-box/docker-compose.yml
 ##########
 @@ -209,48 +209,36 @@ services:
       - variables.env
     hostname: trafficvault
 
-  # Apache Traffic Server (ATS) caches defined here
-  # base image from which all other caches inherit (builds and installs ATS+plugins)
-  tccache:
-    build:
-      context: ../..
-      dockerfile: infrastructure/cdn-in-a-box/cache/Dockerfile
-    image: tccache:latest
-
   # edge cache
   edge:
     privileged: True
     build:
-      context: .
-      dockerfile: edge/Dockerfile
-    depends_on:
-      - enroller
 
 Review comment:
   It's not necessary. Dependency is used to guarantee the startup sequence of container, not the services inside.
   You can take a look at:
   `infrastructure/cdn-in-a-box/dns/set-dns.sh`: waiting for dns
   `to-enroll` of `infrastructure/cdn-in-a-box/traffic_ops/to-access.sh`: waiting for the services enrollment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services