Re: [PR] KAFKA-18220: Refactor AsyncConsumerMetrics to not extend KafkaConsumerMetrics [kafka]

["ShivsundarR (via GitHub)" <gi...@apache.org>]

ShivsundarR commented on PR #20283:
URL: https://github.com/apache/kafka/pull/20283#issuecomment-3248851776

   Thanks @AndrewJSchofield, I used the `consumer-perf-test.sh` and `share-consumer-perf-test.sh` tools to print the metrics before and after the changes.
   
   - For `ClassicKafkaConsumer` - There are no changes in the names/number of metrics.
   - For `AsyncKafkaConsumer`(group.protocol=consumer) - There are no changes in the names/number of metrics.
   
   - For `ShareConsumerImpl`, there is a difference of 6 metrics.
   ```
   These 4 metrics are already recorded as part of KafkaShareConsumerMetrics, previously as AsyncConsumerMetrics inherited KafkaConsumerMetrics, we were getting duplicate metrics.
   consumer-metrics:last-poll-seconds-ago
   consumer-metrics:poll-idle-ratio-avg
   consumer-metrics:time-between-poll-avg
   consumer-metrics:time-between-poll-max
   
   These 2 metrics were also part of KafkaConsumerMetrics, but we do not need them for ShareConsumerImpl. These were present before as AsyncConsumerMetrics inherited KafkaConsumerMetrics.
   consumer-metrics:commit-sync-time-ns-total
   consumer-metrics:committed-time-ns-total
   ```
   
   Hence the difference is expected.
   We have also changes prefix name to include "share" for the `AsyncConsumerMetrics`. This changes prefix for a few metrics but the count remains the same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org