You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/15 12:56:26 UTC
[GitHub] [rocketmq-mqtt] YxAc opened a new pull request, #96: [ISSUE #22] improving codeCov of mqtt.ds
YxAc opened a new pull request, #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96
continuously fix #22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] YxAc commented on a diff in pull request #96: [ISSUE #22] improving codeCov of mqtt.ds
Posted by GitBox <gi...@apache.org>.
YxAc commented on code in PR #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96#discussion_r873166337
##########
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/mq/MqAdmin.java:
##########
@@ -28,9 +28,13 @@ public class MqAdmin {
private DefaultMQAdminExt defaultMQAdminExt;
public MqAdmin(Properties properties) {
+ this(properties.getProperty("NAMESRV_ADDR"));
Review Comment:
add this constructor for optimizing MqFactory to reuse the same code block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] YxAc commented on a diff in pull request #96: [ISSUE #22] improving codeCov of mqtt.ds
Posted by GitBox <gi...@apache.org>.
YxAc commented on code in PR #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96#discussion_r873166668
##########
mqtt-ds/src/test/java/org/apache/rocketmq/mqtt/ds/test/store/TestLmqOffsetStoreManager.java:
##########
@@ -51,12 +51,8 @@
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
-/**
- * @author tianliuliu
- * @date 2022-03-14 11:50
- */
@RunWith(MockitoJUnitRunner.class)
-public class TestOffsetStoreManager {
+public class TestLmqOffsetStoreManager {
Review Comment:
renaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] pingww merged pull request #96: [ISSUE #22] improving codeCov of mqtt.ds
Posted by GitBox <gi...@apache.org>.
pingww merged PR #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #96: [ISSUE #22] improving codeCov of mqtt.ds
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96#issuecomment-1126935693
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#96](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3667da2) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/ac90d5c4918e92d5e096ba9d2e06489b49d7ceca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ac90d5c) will **increase** coverage by `3.10%`.
> The diff coverage is `91.89%`.
```diff
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 44.04% 47.15% +3.10%
==========================================
Files 98 98
Lines 4200 4193 -7
Branches 656 655 -1
==========================================
+ Hits 1850 1977 +127
+ Misses 2016 1878 -138
- Partials 334 338 +4
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/rocketmq/mqtt/ds/meta/FirstTopicManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tZXRhL0ZpcnN0VG9waWNNYW5hZ2VyLmphdmE=) | `71.42% <50.00%> (+24.85%)` | :arrow_up: |
| [...e/rocketmq/mqtt/ds/config/ServiceConfListener.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9jb25maWcvU2VydmljZUNvbmZMaXN0ZW5lci5qYXZh) | `90.90% <100.00%> (+90.90%)` | :arrow_up: |
| [...n/java/org/apache/rocketmq/mqtt/ds/mq/MqAdmin.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tcS9NcUFkbWluLmphdmE=) | `66.66% <100.00%> (+66.66%)` | :arrow_up: |
| [...ava/org/apache/rocketmq/mqtt/ds/mq/MqConsumer.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tcS9NcUNvbnN1bWVyLmphdmE=) | `54.83% <100.00%> (+54.83%)` | :arrow_up: |
| [...java/org/apache/rocketmq/mqtt/ds/mq/MqFactory.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tcS9NcUZhY3RvcnkuamF2YQ==) | `96.29% <100.00%> (+96.29%)` | :arrow_up: |
| [...ava/org/apache/rocketmq/mqtt/ds/mq/MqProducer.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tcS9NcVByb2R1Y2VyLmphdmE=) | `72.22% <100.00%> (+72.22%)` | :arrow_up: |
| [...org/apache/rocketmq/mqtt/ds/mq/MqPullConsumer.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tcS9NcVB1bGxDb25zdW1lci5qYXZh) | `59.09% <100.00%> (+59.09%)` | :arrow_up: |
| [...he/rocketmq/mqtt/ds/notify/NotifyRetryManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9ub3RpZnkvTm90aWZ5UmV0cnlNYW5hZ2VyLmphdmE=) | `26.92% <0.00%> (+26.92%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ac90d5c...3667da2](https://codecov.io/gh/apache/rocketmq-mqtt/pull/96?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] YxAc commented on a diff in pull request #96: [ISSUE #22] improving codeCov of mqtt.ds
Posted by GitBox <gi...@apache.org>.
YxAc commented on code in PR #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96#discussion_r873166448
##########
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/mq/MqFactory.java:
##########
@@ -58,55 +55,28 @@ public static synchronized DefaultMQPullConsumer buildDefaultMQPullConsumer(Stri
}
public static DefaultMQProducer buildDefaultMQProducer(String group, String nameSrv) {
- DefaultMQProducer defaultMQProducer = new DefaultMQProducer();
- defaultMQProducer.setNamesrvAddr(nameSrv);
- defaultMQProducer.setInstanceName(buildInstanceName());
- defaultMQProducer.setVipChannelEnabled(false);
- defaultMQProducer.setProducerGroup(group);
- return defaultMQProducer;
+ MqProducer mqProducer = new MqProducer(nameSrv);
+ mqProducer.setProducerGroup(group);
+ return mqProducer.getDefaultMQProducer();
}
public static DefaultMQPushConsumer buildDefaultMQPushConsumer(String group, String nameSrv,
MessageListener messageListener, Properties properties) {
- DefaultMQPushConsumer defaultMQPushConsumer = new DefaultMQPushConsumer();
- defaultMQPushConsumer.setNamesrvAddr(nameSrv);
- defaultMQPushConsumer.setConsumeMessageBatchMaxSize(1);
- defaultMQPushConsumer.setPullBatchSize(Integer.parseInt(properties.getProperty("pullBatch", "64")));
- if (properties.get(MqConsumer.THREAD_NUM_KEY) != null) {
- defaultMQPushConsumer.setConsumeThreadMin(Integer.valueOf((String) properties.get("threadNum")));
- defaultMQPushConsumer.setConsumeThreadMax(Integer.valueOf((String) properties.get("threadNum")));
- }
- defaultMQPushConsumer.setInstanceName(buildInstanceName());
- defaultMQPushConsumer.setVipChannelEnabled(false);
- defaultMQPushConsumer.setConsumerGroup(group);
- if (messageListener instanceof MessageListenerOrderly) {
- defaultMQPushConsumer.registerMessageListener((MessageListenerOrderly) messageListener);
- } else {
- defaultMQPushConsumer.registerMessageListener((MessageListenerConcurrently) messageListener);
- }
- return defaultMQPushConsumer;
+ MqConsumer mqConsumer = new MqConsumer(properties, nameSrv);
Review Comment:
reusing the same code block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] YxAc commented on a diff in pull request #96: [ISSUE #22] improving codeCov of mqtt.ds
Posted by GitBox <gi...@apache.org>.
YxAc commented on code in PR #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96#discussion_r873166000
##########
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/meta/FirstTopicManager.java:
##########
@@ -108,6 +113,9 @@ public void checkFirstTopicIfCreated(String firstTopic) {
}
private void updateTopicRoute(String firstTopic) {
+ if (StringUtils.isBlank(firstTopic)) {
Review Comment:
bug of blank judgment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] YxAc commented on a diff in pull request #96: [ISSUE #22] improving codeCov of mqtt.ds
Posted by GitBox <gi...@apache.org>.
YxAc commented on code in PR #96:
URL: https://github.com/apache/rocketmq-mqtt/pull/96#discussion_r873165923
##########
mqtt-ds/src/main/java/org/apache/rocketmq/mqtt/ds/meta/FirstTopicManager.java:
##########
@@ -82,6 +82,11 @@ public void init() throws MQClientException {
}, 0, 5, TimeUnit.SECONDS);
}
+ public void initMQAdminExt() throws MQClientException {
Review Comment:
take it out for ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org