[GitHub] [flink] wuchong commented on a diff in pull request #19746: [FLINK-27630][table-planner] Add maven-source-plugin for table planne…

[GitBox <gi...@apache.org>]

wuchong commented on code in PR #19746:
URL: https://github.com/apache/flink/pull/19746#discussion_r886484091


##########
flink-table/flink-table-planner/pom.xml:
##########
@@ -427,6 +427,30 @@ under the License.
 					</execution>
 				</executions>
 			</plugin>
+
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-source-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>attach-test-sources</id>
+						<goals>
+							<goal>test-jar-no-fork</goal>
+						</goals>
+						<configuration>
+							<archive>
+								<!-- Globally exclude maven metadata, because it may accidentally bundle files we don't intend to -->
+								<addMavenDescriptor>false</addMavenDescriptor>
+							</archive>
+							<includes>
+								<include>**/factories/**</include>

Review Comment:
   Could you add a comment why introducing this plugin and why only include factories sources? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org