You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@clerezza.apache.org by "Tsuyoshi Ito (JIRA)" <ji...@apache.org> on 2010/10/06 11:35:31 UTC
[jira] Created: (CLEREZZA-316) Update where a GraphNode accessible
in ssp bases on a graph injected with service
Update where a GraphNode accessible in ssp bases on a graph injected with service
---------------------------------------------------------------------------------
Key: CLEREZZA-316
URL: https://issues.apache.org/jira/browse/CLEREZZA-316
Project: Clerezza
Issue Type: Improvement
Reporter: Tsuyoshi Ito
Fix if this can easily be prevented
Possibly: have a service returning an unsecured graph, maybe add a method getUnsecuredMGrah to SecuredMGraph, this method would check permissions while the retuned mgarph would no longer need to. => to do in a dedicated issue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CLEREZZA-316) Update where a GraphNode accessible
in ssp bases on a graph injected with service
Posted by "Tsuyoshi Ito (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsuyoshi Ito reassigned CLEREZZA-316:
-------------------------------------
Assignee: Manuel Innerhofer
> Update where a GraphNode accessible in ssp bases on a graph injected with service
> ---------------------------------------------------------------------------------
>
> Key: CLEREZZA-316
> URL: https://issues.apache.org/jira/browse/CLEREZZA-316
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Tsuyoshi Ito
> Assignee: Manuel Innerhofer
>
> Fix if this can easily be prevented
>
> Possibly: have a service returning an unsecured graph, maybe add a method getUnsecuredMGrah to SecuredMGraph, this method would check permissions while the retuned mgarph would no longer need to. => to do in a dedicated issue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-316) Update where a GraphNode
accessible in ssp bases on a graph injected with service
Posted by "Manuel Innerhofer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918502#action_12918502 ]
Manuel Innerhofer commented on CLEREZZA-316:
--------------------------------------------
you're right.. fixed it
> Update where a GraphNode accessible in ssp bases on a graph injected with service
> ---------------------------------------------------------------------------------
>
> Key: CLEREZZA-316
> URL: https://issues.apache.org/jira/browse/CLEREZZA-316
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Tsuyoshi Ito
> Assignee: Manuel Innerhofer
>
> Fix if this can easily be prevented
>
> Possibly: have a service returning an unsecured graph, maybe add a method getUnsecuredMGrah to SecuredMGraph, this method would check permissions while the retuned mgarph would no longer need to. => to do in a dedicated issue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLEREZZA-316) Update where a GraphNode accessible
in ssp bases on a graph injected with service
Posted by "Manuel Innerhofer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manuel Innerhofer resolved CLEREZZA-316.
----------------------------------------
Resolution: Fixed
> Update where a GraphNode accessible in ssp bases on a graph injected with service
> ---------------------------------------------------------------------------------
>
> Key: CLEREZZA-316
> URL: https://issues.apache.org/jira/browse/CLEREZZA-316
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Tsuyoshi Ito
> Assignee: Manuel Innerhofer
>
> Fix if this can easily be prevented
>
> Possibly: have a service returning an unsecured graph, maybe add a method getUnsecuredMGrah to SecuredMGraph, this method would check permissions while the retuned mgarph would no longer need to. => to do in a dedicated issue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-316) Update where a GraphNode
accessible in ssp bases on a graph injected with service
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918540#action_12918540 ]
Reto Bachmann-Gmür commented on CLEREZZA-316:
---------------------------------------------
In one of the patches I see:
- systemGraph.add(new TripleImpl(instance, PLATFORM.languages,
- listNode));
+ Lock writeLock = systemGraph.getLock().writeLock();
+ writeLock.lock();
+ try {
+ systemGraph.add(new TripleImpl(instance, PLATFORM.languages, listNode));
+ } finally {
+ writeLock.unlock();
+ }
why this?
> Update where a GraphNode accessible in ssp bases on a graph injected with service
> ---------------------------------------------------------------------------------
>
> Key: CLEREZZA-316
> URL: https://issues.apache.org/jira/browse/CLEREZZA-316
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Tsuyoshi Ito
> Assignee: Manuel Innerhofer
>
> Fix if this can easily be prevented
>
> Possibly: have a service returning an unsecured graph, maybe add a method getUnsecuredMGrah to SecuredMGraph, this method would check permissions while the retuned mgarph would no longer need to. => to do in a dedicated issue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-316) Update where a GraphNode
accessible in ssp bases on a graph injected with service
Posted by "Hasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918496#action_12918496 ]
Hasan commented on CLEREZZA-316:
--------------------------------
I think checkRead is superfluous.
+ /**
+ * Returns the wrapped LockableMGraph if the caller has all access rights,
+ * otherwise an AccessControlException is thrown.
+ *
+ * @return the wrapped LockableMGraph.
+ */
+ public LockableMGraph getUnsecuredMGraph() {
+ checkWrite();
+ checkRead();
+ return wrapped;
+ }
+
}
> Update where a GraphNode accessible in ssp bases on a graph injected with service
> ---------------------------------------------------------------------------------
>
> Key: CLEREZZA-316
> URL: https://issues.apache.org/jira/browse/CLEREZZA-316
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Tsuyoshi Ito
> Assignee: Manuel Innerhofer
>
> Fix if this can easily be prevented
>
> Possibly: have a service returning an unsecured graph, maybe add a method getUnsecuredMGrah to SecuredMGraph, this method would check permissions while the retuned mgarph would no longer need to. => to do in a dedicated issue
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.