You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/25 07:43:22 UTC
[GitHub] [ozone] mukul1987 commented on a change in pull request #2791: HDDS-5921. [Merge rocksdb in datanode]Decouple DatanodeStore impl classes from container.
mukul1987 commented on a change in pull request #2791:
URL: https://github.com/apache/ozone/pull/2791#discussion_r814539728
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/BlockUtils.java
##########
@@ -56,24 +56,21 @@ private BlockUtils() {
* the caller must close it after using it.
* If another thread attempts to open the same container when it is already
* opened by this thread, the other thread will get a RocksDB exception.
- * @param containerID The containerID
* @param containerDBPath The absolute path to the container database folder
* @param schemaVersion The Container Schema version
* @param conf Configuration
* @return Handler to the given container.
* @throws IOException
*/
- public static DatanodeStore getUncachedDatanodeStore(long containerID,
+ public static DatanodeStore getUncachedDatanodeStore(
Review comment:
Lets modify the comments as well here, as now this may return the DB for the disk. Please modify the comment at line 55 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org